-
Notifications
You must be signed in to change notification settings - Fork 381
chore(example): scope setup caches and refresh each demo installation #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fadi-george
merged 4 commits into
OneSignal:main
from
OskarEichler:codex/onesignal-demo-setup-cache
Aug 31, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
69c1894
fix(example): scope setup caches and refresh each demo installation
OskarEichler 87837e8
Use Vite+ package removal command
OskarEichler 21a396a
Fix Vite+ demo package registration
OskarEichler 5b6177c
refactor(example): simplify demo tarball cache and keep Metro env inv…
fadi-george File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ dist | |
| android/build | ||
| *.tgz | ||
| .rn-sdk-source.stamp | ||
| .rn-demo-env.stamp | ||
|
|
||
| # OSX | ||
| # | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,18 @@ | ||
| const { getDefaultConfig, mergeConfig } = require('@react-native/metro-config'); | ||
| const { FileStore } = require('metro-cache'); | ||
| const path = require('node:path'); | ||
|
|
||
| /** | ||
| * Metro configuration | ||
| * https://reactnative.dev/docs/metro | ||
| * | ||
| * @type {import('@react-native/metro-config').MetroConfig} | ||
| */ | ||
| const config = {}; | ||
| const config = { | ||
| cacheStores: [ | ||
| new FileStore({ root: path.join(__dirname, 'node_modules/.cache/metro/transform') }), | ||
| ], | ||
| fileMapCacheDirectory: path.join(__dirname, 'node_modules/.cache/metro/file-map'), | ||
| }; | ||
|
|
||
| module.exports = mergeConfig(getDefaultConfig(__dirname), config); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't insert bun here. Use
vp remove react-native-onesignal.vp execfor pack is fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the current branch. The setup now uses Vite+ directly:
vp remove react-native-onesignalfor removal andvp addfor the packed tarball. No Bun command remains in this path. Bash syntax checks and the complete Vite+ suite (262 tests) pass.