-
Notifications
You must be signed in to change notification settings - Fork 381
chore(example): validate inputs and keep controls stable and accessible #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fadi-george
merged 16 commits into
OneSignal:main
from
OskarEichler:codex/onesignal-demo-controls
Aug 28, 2026
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ee1f906
fix(example): validate inputs and keep controls stable and accessible
OskarEichler db9b00a
Remove out-of-scope demo accessibility changes
OskarEichler da4f686
Remove out-of-scope demo accessibility changes
OskarEichler 7c73bd1
Remove out-of-scope demo accessibility changes
OskarEichler b39c86c
Remove out-of-scope demo accessibility changes
OskarEichler 930779e
Remove out-of-scope demo accessibility changes
OskarEichler b8c35b5
Remove out-of-scope demo accessibility changes
OskarEichler 262a323
Remove out-of-scope demo accessibility changes
OskarEichler 78387af
Remove out-of-scope demo accessibility changes
OskarEichler 5336070
Remove out-of-scope demo accessibility changes
OskarEichler 468e2fc
Narrow demo input validation changes
OskarEichler ef0d375
Narrow demo input validation changes
OskarEichler 0ffd59c
Narrow demo input validation changes
OskarEichler 2b288f1
Narrow demo input validation changes
OskarEichler fe3bb48
Keep only outcome validation changes
OskarEichler fe74dc4
chore(example): refresh demo dependency locks
fadi-george File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ export function userDataFromJson(json: Record<string, unknown>): UserData { | |
| const properties = (json.properties as Record<string, unknown>) ?? {}; | ||
| const subscriptions = (json.subscriptions as Array<Record<string, unknown>>) ?? []; | ||
|
|
||
| const aliases: Record<string, string> = {}; | ||
| const aliases: Record<string, string> = Object.create(null); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. excessive, dont really need this change |
||
| for (const [key, value] of Object.entries(identity)) { | ||
| if (key !== 'external_id' && key !== 'onesignal_id') { | ||
| aliases[key] = String(value); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont really need the accessibility changes for the sdk demos