Skip to content

fix(ios): forward every application delegate assignment #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadi-george merged 2 commits into from
Sep 1, 2026
Merged

fix(ios): forward every application delegate assignment #1979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73db4ac
fix(ios): forward every application delegate assignment
OskarEichler Aug 27, 2026
cd6ef37
fix(ios): inject launch hook once per delegate class
fadi-george Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions ios/RCTOneSignal/UIApplication+RCTOnesignal.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,34 @@ + (void)load {
});
}

- (void)setOneSignalReactNativeDelegate:(id<UIApplicationDelegate>)delegate {
// A class may only be injected once. A second exchange would swap the original
// implementation back and drop OneSignal out of the launch chain.
static BOOL shouldInjectIntoDelegateClass(Class delegateClass) {
static NSMutableSet<Class> *injectedClasses;
static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{
Class delegateClass = [delegate class];
injectedClasses = [NSMutableSet set];
});

@synchronized(injectedClasses) {
if ([injectedClasses containsObject:delegateClass])
return NO;

[injectedClasses addObject:delegateClass];
return YES;
}
}

- (void)setOneSignalReactNativeDelegate:(id<UIApplicationDelegate>)delegate {
Class delegateClass = [delegate class];
if (delegateClass && shouldInjectIntoDelegateClass(delegateClass)) {
injectSelector(
self.class,
@selector(oneSignalApplication:didFinishLaunchingWithOptions:),
delegateClass, @selector(application:didFinishLaunchingWithOptions:));
[self setOneSignalReactNativeDelegate:delegate];
});
}

[self setOneSignalReactNativeDelegate:delegate];
}

- (BOOL)oneSignalApplication:(UIApplication *)application
Expand Down
Loading