Skip to content

fix(examples): deduplicate tooltip initialization - #52

Closed
fadi-george wants to merge 1 commit into
mainfrom
fadi/sdk-5124
Closed

fix(examples): deduplicate tooltip initialization#52
fadi-george wants to merge 1 commit into
mainfrom
fadi/sdk-5124

Conversation

@fadi-george

@fadi-george fadi-george commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Share in-flight tooltip initialization and allow later retries after non-fatal failures.

Details

Motivation

Linear: SDK-5125, SDK-5124.

Both Capacitor demos now share concurrent initialization calls, cache completion only after successful parsing, and clear pending state on every exit without adding retry timers. Adapted from OneSignal/react-native-onesignal#1984.

Scope

Example tooltip helpers only; SDK APIs are unchanged.

Testing

  • vp test run: 179 tests pass; coverage thresholds pass.
  • Focused vp check for both tooltip helpers: passes.
  • Both examples/demo and examples/demo_pods production web builds: pass.
  • Mocked-fetch diagnostic: concurrent calls share one promise, malformed JSON permits a later retry, and successful data remains cached.
  • Full vp check has an unchanged baseline README.md formatting failure.

Checklist

  • I have filled out all required sections
  • PR does one thing
  • No public API changes
  • Automated tests pass
  • Diff reviewed
Open in Web Open in Cursor 

Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
@fadi-george
fadi-george marked this pull request as ready for review September 1, 2026 21:45
@fadi-george
fadi-george requested a review from a team September 1, 2026 21:45
@cursor
cursor Bot deleted the fadi/sdk-5124 branch September 1, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants