Skip to content

fix(examples): reject malformed notification responses - #51

Closed
fadi-george wants to merge 4 commits into
mainfrom
fadi/sdk-5118
Closed

fix(examples): reject malformed notification responses#51
fadi-george wants to merge 4 commits into
mainfrom
fadi/sdk-5118

Conversation

@fadi-george

@fadi-george fadi-george commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Reject malformed or ambiguous notification success bodies without retrying them.

Details

Motivation

Linear: SDK-5125, SDK-5118.

Only recognized subscription-indexing response shapes remain retryable. Null, primitive, array, malformed JSON, and ambiguous object bodies fail immediately. Adapted to CapacitorHttp and fetch from OneSignal/react-native-onesignal#1983.

Scope

All notification-send paths that exist in this repository: demo, demo_pods, demo_cap7, and demo-no-location. Published SDK APIs are unchanged.

Testing

  • vp test run: 14 files and 224 tests pass; coverage thresholds pass.
  • Added cases for malformed JSON, null, primitive, array, valid success, recognized transient failures, and ambiguous objects in all three retrying demos.
  • Focused vp check passes for all changed service, test, Angular component, and no-location files.
  • Production web builds pass for demo, demo_pods, demo_cap7, and demo-no-location.
  • Full vp check has an unchanged baseline README.md formatting failure.

Affected code checklist

  • REST API requests
  • Public API changes

Checklist

  • I have filled out all required sections
  • PR does one thing
  • No public API changes
  • Automated tests pass
  • Diff reviewed
Open in Web Open in Cursor 

cursoragent and others added 2 commits September 1, 2026 21:41
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
@fadi-george
fadi-george marked this pull request as ready for review September 1, 2026 21:45
@fadi-george
fadi-george requested a review from a team September 1, 2026 21:45
cursoragent and others added 2 commits September 1, 2026 21:48
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
@cursor
cursor Bot deleted the fadi/sdk-5118 branch September 1, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants