fix(examples): reject malformed notification responses - #51
Closed
fadi-george wants to merge 4 commits into
Closed
Conversation
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
fadi-george
marked this pull request as ready for review
September 1, 2026 21:45
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Reject malformed or ambiguous notification success bodies without retrying them.
Details
Motivation
Linear: SDK-5125, SDK-5118.
Only recognized subscription-indexing response shapes remain retryable. Null, primitive, array, malformed JSON, and ambiguous object bodies fail immediately. Adapted to CapacitorHttp and fetch from OneSignal/react-native-onesignal#1983.
Scope
All notification-send paths that exist in this repository:
demo,demo_pods,demo_cap7, anddemo-no-location. Published SDK APIs are unchanged.Testing
vp test run: 14 files and 224 tests pass; coverage thresholds pass.vp checkpasses for all changed service, test, Angular component, and no-location files.demo,demo_pods,demo_cap7, anddemo-no-location.vp checkhas an unchanged baselineREADME.mdformatting failure.Affected code checklist
Checklist