fix(examples): validate outcomes and preserve keys - #50
Closed
fadi-george wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Reject invalid outcome values and preserve special dictionary keys in both demos.
Details
Motivation
Linear: SDK-5125, SDK-5122.
Outcome values must be present, complete, and finite. Multi-pair dictionaries now preserve keys such as
__proto__. JSON event properties were already object-only; native header-title and inline-control remount patterns do not exist in these web demos. Adapted from applicable parts of OneSignal/react-native-onesignal#1982.Scope
Demo input handling only; accessibility and SDK APIs are unchanged.
Testing
vp test run: 179 tests pass; coverage thresholds pass.vp checkfor all four changed modal files: passes.examples/demoandexamples/demo_podsproduction web builds: pass.vp checkhas an unchanged baselineREADME.mdformatting failure.Affected code checklist
Checklist