fix(examples): harden cache and async lifecycle - #48
Closed
fadi-george wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Key demo installs to packed bytes and prevent stale async startup state.
Details
Motivation
Linear: SDK-5125.
The shared stable tarball is retained when packed bytes are unchanged, while each demo records the tarball hash it installed. Effect-local change flags protect live subscription, permission, and user events from stale startup snapshots; cancellation and request sequencing prevent late user updates. Adapted from applicable Capacitor equivalents of OneSignal/react-native-onesignal#1985 and #1981. Metro/env cache handling was not ported.
Scope
Demo setup and lifecycle code only; SDK APIs are unchanged.
Testing
vp test run: 179 tests pass; coverage thresholds pass.vp checkfor both changed hooks: passes.bash -n examples/setup.sh: passes.examples/demoandexamples/demo_podsproduction web builds: pass.vpxcommand because only the localvpexecutable is available; cache behavior was isolated with a no-op sync shim.vp checkhas an unchanged baselineREADME.mdformatting failure.Checklist