Skip to content

fix(scaffold): align v4 preview CD versioning#16232

Merged
Alive-Fish merged 3 commits into
devfrom
fix/v4-distribution-cd-versioning
Jun 30, 2026
Merged

fix(scaffold): align v4 preview CD versioning#16232
Alive-Fish merged 3 commits into
devfrom
fix/v4-distribution-cd-versioning

Conversation

@Alive-Fish

@Alive-Fish Alive-Fish commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align v4 template publish versions with preview VSIX date-stamped versions for even minor bases.
  • Keep the v4 template config sync script, publish script, and generated zip floor metadata consistent.

Validation

  • cd packages/fx-core && npx vitest run --config vitest.config.ts tests/v4/distribution/templateConfig.test.ts

Affected tests green.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests unknown

Why these tests: All changed files are CI/CD scripts, GitHub workflows, and distribution config/tests — trivial/infra changes with no vscode template modifications, so only 2 smoke plans are selected.

Branch diff: fix/v4-distribution-cd-versioningdev

Plans run:

  • Basic_Custom_Engine_Azure_OpenAI_ts_Copilot_Remote_Debug
  • General_Teams_Agent_OpenAI_py_Remote_Debug

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests unknown
ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
fix/v4-distribution-cd-versioning and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

E2E Test Selection — AI Selected

Why these tests: fx-core templateConfig.ts changes (rule 1) and the general-purpose generateV4Zip.js template script trigger teamsApp/, teamsAgent/, declarativeAgent/, and feature/multienv coverage; .github scripts are infra-only (rule 9) and excluded.

Cases selected (21):

  • ./teamsApp/basicBot.tests.ts
  • ./teamsApp/basicMessageExtension.tests.ts
  • ./teamsApp/basicTab.tests.ts
  • ./teamsAgent/DebugCustomCopilotBasicBot.tests.ts
  • ./teamsAgent/teamsCollaboratorAgent.tests.ts
  • ./teamsAgent/DebugCustomCopilotRagAiSearchBot.tests.ts
  • ./teamsAgent/DebugCustomCopilotRagBasicBot.tests.ts
  • ./declarativeAgent/DeclarativeAgentBasic.tests.ts
  • ./declarativeAgent/DeclarativeAgentWithApiKeyAuth.tests.ts
  • ./declarativeAgent/DeclarativeAgentWithOAuth.tests.ts
  • ./declarativeAgent/DeclarativeAgentInvalidManifestShape.tests.ts
  • ./declarativeAgent/mcp/DeclarativeAgentMCPNoAuth.tests.ts
  • ./declarativeAgent/mcp/DeclarativeAgentMCPAuthEdgeCases.tests.ts
  • ./declarativeAgent/mcp/DeclarativeAgentMCPWithAuth.tests.ts
  • ./declarativeAgent/DeclarativeAgentWithEntra.tests.ts
  • ./declarativeAgent/typespec/typespec.withoutAction.tests.ts
  • ./declarativeAgent/typespec/typespec.withAction.tests.ts
  • ./declarativeAgent/DeclarativeAgentWithNoneAuth.tests.ts
  • ./declarativeAgent/addKnowledge/AddWebSearchByAll.tests.ts
  • ./declarativeAgent/addKnowledge/AddWebSearchByUrl.tests.ts
  • ./feature/multienv.tests.ts

View pipeline run

Need to run more tests?

Comment on this PR:

  • /e2e-run ./path/to/test.tests.ts — add specific cases to AI selection
  • /e2e-run-all — run all e2e cases

Then re-run the workflow.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests unknown

Why these tests: All changed files are CI/infra scripts and internal distribution config (no templates/vscode/** or packages/vscode-extension/** paths), so this qualifies as trivial/infra — returning 2 smoke plans only.

Branch diff: fix/v4-distribution-cd-versioningdev

Plans run:

  • Basic_Custom_Engine_Azure_OpenAI_ts_Copilot_Remote_Debug
  • General_Teams_Agent_OpenAI_py_Remote_Debug

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests unknown
ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
fix/v4-distribution-cd-versioning and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns v4 template publish/versioning behavior with the VSIX “preview” version minting rules so that preview template builds minted off an even-minor stable base publish into the next odd-minor, date-stamped lane (e.g., 6.10.x-beta.<date>6.11.<date>), keeping the v4 channel’s version/range/floor metadata consistent across scripts and fx-core.

Changes:

  • Update computeV4PublishVersion to bump even-minor preview bases to the next odd minor and stamp the build date into the patch.
  • Make v4 template range computation follow the published (clean) version rather than the raw minted version.
  • Update CD/build scripts and unit tests to reflect and validate the new versioning behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
templates/scripts/generateV4Zip.js Updates the build-time v4 publish version computation used for floor.json and templates.zip packaging.
packages/fx-core/tests/v4/distribution/templateConfig.test.ts Adjusts/adds tests to validate even-minor preview → odd-minor date-stamped behavior and the resulting config/range.
packages/fx-core/src/v4/distribution/templateConfig.ts Updates canonical publish version and range logic used to generate v4 template distribution config.
.github/scripts/v4/sync-v4-template-config.js Keeps the build-independent CD “sync v4 config” script aligned with the canonical publish version/range behavior.
.github/scripts/v4/publish-v4-channel.sh Simplifies publish invariants to rely on the synced v4.localVersion as the single source of truth for the clean publish version.

Comment thread packages/fx-core/src/v4/distribution/templateConfig.ts Outdated
Comment thread templates/scripts/generateV4Zip.js Outdated
Comment thread .github/scripts/v4/sync-v4-template-config.js Outdated
Comment thread .github/scripts/v4/publish-v4-channel.sh
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.46%. Comparing base (5d7c434) to head (3d315c9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #16232   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         624      624           
  Lines       31816    31817    +1     
  Branches     7437     7438    +1     
=======================================
+ Hits        27509    27510    +1     
  Misses       2479     2479           
  Partials     1828     1828           
Files with missing lines Coverage Δ
...ages/fx-core/src/v4/distribution/templateConfig.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

❌ VscUse Test Plan — Tests failure

Why these tests: All changed files are infra/CI/versioning scripts (.github/scripts, packages/fx-core/src/v4/distribution, templates/scripts) with no template or VS Code extension changes, so only 2 smoke plans are selected as a basic sanity check.

Branch diff: fix/v4-distribution-cd-versioningdev

Plans run:

  • Basic_Custom_Engine_Azure_OpenAI_ts_Copilot_Remote_Debug
  • General_Teams_Agent_OpenAI_py_Remote_Debug

Step Status
1️⃣ Build VSIX (CD) ✅ Done
2️⃣ Build Docker image ✅ Done
3️⃣ Run UI tests ❌ Tests failure

🎯 Actual UI test run
🔗 Full pipeline results
📊 Detailed test report

ℹ️ How were these tests selected?

GitHub Copilot (Claude Sonnet 4.6, high reasoning) analysed the PR title, description, and the diff between
fix/v4-distribution-cd-versioning and dev
to pick the most relevant test plans from packages/tests/vscuse/Index.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants