Fix Node 22 SPFx sample deploy failure by correcting ESLint plugin runtime dependency

[Copilot]

The sample-todo-list-with-spfx|ubuntu-latest|node 22|dev Actions job failed during atk deploy --env dev because ESLint could not load typescript-eslint from the shared flat config. This PR fixes the dependency declaration so the config resolves correctly in CI/runtime install contexts.

• Root cause in shared lint config packaging

  • packages/eslint-plugin-teamsfx/config/shared.mjs imports typescript-eslint at runtime.
  • typescript-eslint was declared only in devDependencies, which is insufficient when the config is consumed outside that package’s dev environment.

• Dependency declaration fix

  • Moved typescript-eslint from devDependencies to dependencies in packages/eslint-plugin-teamsfx/package.json.
  • Updated packages/eslint-plugin-teamsfx/pnpm-lock.yaml to match the new dependency scope.

• Impact

  • Ensures consumers of @microsoft/eslint-plugin-teamsfx can resolve typescript-eslint whenever config/shared.mjs is imported (including SPFx sample deploy/lint in CI on Node 22).

{
  "dependencies": {
    "requireindex": "^1.2.0",
    "typescript-eslint": "^8.56.0"
  }
}