Skip to content

cherry-pick: set Azure login status to signed in after token retrieval (PR #15958 → dev)#16001

Draft
Copilot wants to merge 1 commit into
devfrom
copilot/cherry-pick-15958
Draft

cherry-pick: set Azure login status to signed in after token retrieval (PR #15958 → dev)#16001
Copilot wants to merge 1 commit into
devfrom
copilot/cherry-pick-15958

Conversation

Copilot AI commented May 21, 2026

Copy link
Copy Markdown
Contributor

After a successful Azure login, AzureAccountManager.currentStatus was not being updated to loggedIn and listeners were not notified, leaving the extension UI and dependent features in a stale unauthenticated state.

Changes

  • azureLogin.ts: After building the TokenCredential on successful login, immediately set AzureAccountManager.currentStatus = loggedIn and call void this.notifyStatus() before returning the credential.
// packages/vscode-extension/src/commonlib/azureLogin.ts
const credential: TokenCredential = { ... };
AzureAccountManager.currentStatus = loggedIn;  // ← added
void this.notifyStatus();                        // ← added

return credential;

Notes

Both changes from PR #15958 were already present in dev:

  • The azureLogin.ts fix (lines 174–175)
  • Version is already at 6.10.0, ahead of the 6.10.0-rc.0 bump that was release-branch-specific

No code modifications were required; this PR confirms the cherry-pick is complete.

Copilot AI changed the title [WIP] Cherry pick changes from PR 15958 to dev cherry-pick: set Azure login status to signed in after token retrieval (PR #15958 → dev) May 21, 2026
Copilot AI requested a review from HuihuiWu-Microsoft May 21, 2026 08:21
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (893bac5) to head (eb225b8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #16001   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         597      597           
  Lines       37412    37412           
  Branches     6987     6997   +10     
=======================================
+ Hits        34926    34927    +1     
+ Misses       1837     1836    -1     
  Partials      649      649           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cherry-pick] Cherry pick https://github.com/OfficeDev/microsoft-365-agents-toolkit/pull/15958 to dev

2 participants