Skip to content

Add test case for FLOWS/FLORES with NNC and BCCON - #1134

Open
totto82 wants to merge 1 commit into
masterfrom
flows
Open

Add test case for FLOWS/FLORES with NNC and BCCON#1134
totto82 wants to merge 1 commit into
masterfrom
flows

Conversation

@totto82

@totto82 totto82 commented Feb 9, 2024

Copy link
Copy Markdown
Member

Motivation.
OPM/opm-models#874

@totto82

totto82 commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

The fix is merged. I really want to add this to regression to avoid further issues. Review?

@bska

bska commented Feb 13, 2024

Copy link
Copy Markdown
Member

I really want to add this to regression to avoid further issues.

Okay, but maybe you can start adding some real unit tests as well? Regression tests are good as far as they go, but it's a lot easier to catch problems with tests that don't require building and running the full simulator.

@totto82

totto82 commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

Okay, but maybe you can start adding some real unit tests as well? Regression tests are good as far as they go, but it's a lot easier to catch problems with tests that don't require building and running the full simulator.

I dont think it would be easy to make a simple unit test for this without including the full assembly code and the output code, for that we need to include the full simulator anyway. Yes, unit tests are good to have, but regression tests are better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants