tests: field totals must not change when part of the grid is refined - #7315
Draft
hnil wants to merge 1 commit into
Draft
tests: field totals must not change when part of the grid is refined#7315hnil wants to merge 1 commit into
hnil wants to merge 1 commit into
Conversation
…ined Compares the refined and unrefined twins of SPE1CASE1_CARFIN1-3DCORNERPOINT_XYZ against each other, so no reference data is involved and the test states the property directly. The tolerance is 1e-3: an order of magnitude above the discretisation drift between the two grids (~1.3e-4 by the end of the run) and an order below the ~1.4e-2 error it catches. Needs the twin deck from OPM/opm-tests#1558, and the fixes in OPM#7245 and OPM#7244 - on master all cell-based output is zero once an LGR is present. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
hnil
added
the
manual:irrelevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comparison test asserting that refining part of the grid does not change the field totals. The two decks are identical but for the
CARFINblock, so they are compared against each other — no reference data, and the test states the property directly rather than freezing whatever numbers we happen to produce today.Stacked, and red until the rest lands:
With all three:
REL_TOLis 1e-3 — an order of magnitude above the discretisation drift between the two grids (~1.3e-4 at the end of the run) and an order below the ~1.4e-2 error it catches.Motivation: no LGR deck in opm-tests requests region FIP today, and only one requests FPR, so nothing in CI noticed that LGR output had stopped working.