Skip to content

remove the usage of Schedule::filterConnections() #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bska merged 1 commit into from
Feb 10, 2026
Merged

remove the usage of Schedule::filterConnections() #6806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions opm/simulators/flow/CpGridVanguard.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,6 @@ class CpGridVanguard : public FlowBaseVanguard<TypeTag>
}
#endif

// removing some connection located in inactive grid cells
void filterConnections_()
{
this->doFilterConnections_(this->schedule());
}

// \Note: this globalTrans_ is used for domain decomposition and INIT file output.
// It only contains trans_ due to permeability and does not contain thermalHalfTrans_,
// diffusivity_ abd dispersivity_. The main reason is to reduce the memory usage for rank 0
Expand Down
1 change: 0 additions & 1 deletion opm/simulators/flow/FlowBaseVanguard.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ class FlowBaseVanguard : public BaseVanguard<TypeTag>,
void callImplementationInit()
{
asImp_().createGrids_();
asImp_().filterConnections_();
std::string outputDir = Parameters::Get<Parameters::OutputDir>();
bool enableEclCompatFile = !Parameters::Get<Parameters::EnableOpmRstFile>();
asImp_().updateOutputDir_(outputDir, enableEclCompatFile);
Expand Down
31 changes: 0 additions & 31 deletions opm/simulators/flow/GenericCpGridVanguard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,37 +600,6 @@ void GenericCpGridVanguard<ElementMapper,GridView,Scalar>::addLgrsUpdateLeafView
grid.addLgrsUpdateLeafView(cells_per_dim_vec, startIJK_vec, endIJK_vec, lgrName_vec);
};

template<class ElementMapper, class GridView, class Scalar>
void GenericCpGridVanguard<ElementMapper,GridView,Scalar>::
doFilterConnections_(Schedule& schedule)
{
// We only filter if we hold the global grid. Otherwise the filtering
// is done after load balancing as in the future the other processes
// will hold an empty partition for the global grid and hence filtering
// here would remove all well connections.
if (this->equilGrid_ != nullptr) {
ActiveGridCells activeCells(equilGrid().logicalCartesianSize(),
equilGrid().globalCell().data(),
equilGrid().size(0));

schedule.filterConnections(activeCells);
}

#if HAVE_MPI
try {
// Broadcast another time to remove inactive peforations on
// slave processors.
eclBroadcast(FlowGenericVanguard::comm(), schedule);
}
catch (const std::exception& broadcast_error) {
OpmLog::error(fmt::format("Distributing properties to all processes failed\n"
"Internal error message: {}", broadcast_error.what()));
MPI_Finalize();
std::exit(EXIT_FAILURE);
}
#endif // HAVE_MPI
}

template<class ElementMapper, class GridView, class Scalar>
const Dune::CpGrid&
GenericCpGridVanguard<ElementMapper,GridView,Scalar>::equilGrid() const
Expand Down
3 changes: 0 additions & 3 deletions opm/simulators/flow/GenericCpGridVanguard.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ class GenericCpGridVanguard {
virtual void allocTrans() = 0;
virtual double getTransmissibility(unsigned I, unsigned J) const = 0;

// removing some connection located in inactive grid cells
void doFilterConnections_(Schedule& schedule);

Scalar computeCellThickness(const Element& element) const;

std::unique_ptr<Dune::CpGrid> grid_;
Expand Down