Skip to content

Unify linear solvers #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blattms merged 11 commits into from
Oct 13, 2020
Merged

Unify linear solvers #2848

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
65817c9
Removed old amg/cpr code that can be replaced.
atgeirr Jul 8, 2020
1c208e9
Avoid unnecessary extra matrix manipulation.
atgeirr Oct 10, 2020
0a70d95
Refactor shouldCreateSolver().
atgeirr Oct 11, 2020
00438c4
Remove unused parts (not just comment out).
atgeirr Oct 11, 2020
842afd3
Refactor setupPropertyTree().
atgeirr Oct 11, 2020
30a4fe5
Add "amg" option to --linear-solver-configuration.
atgeirr Oct 11, 2020
3858804
Fix logic of shouldCreateSolver().
atgeirr Oct 11, 2020
f169cf9
Remove --linear-solver-configuration-file parameter.
atgeirr Oct 12, 2020
316b289
Rename parameter --linear-solver-configuration to --linsolver.
atgeirr Oct 12, 2020
dedbe78
Copyright additions.
atgeirr Oct 12, 2020
ea0abd1
Bugfix: do not substr() on too small strings.
atgeirr Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opm/simulators/linalg/setupPropertyTree_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ setupPropertyTree(FlowLinearSolverParameters p) // Note: copying the parameters
std::string conf = p.linsolver_;

// Get configuration from file.
if (conf.substr(conf.size() - 5, 5) == ".json") {
if (conf.size() > 5 && conf.substr(conf.size() - 5, 5) == ".json") { // the ends_with() method is not available until C++20
Comment thread
blattms marked this conversation as resolved.
#if BOOST_VERSION / 100 % 1000 > 48
try {
boost::property_tree::ptree prm;
Expand Down