Fix AliasName subcategory browse continuation#4040
Merged
marcschier merged 2 commits intoJul 21, 2026
Merged
Conversation
marcschier
approved these changes
Jul 19, 2026
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4040 +/- ##
==========================================
- Coverage 73.85% 73.55% -0.31%
==========================================
Files 1345 1345
Lines 179988 180056 +68
Branches 31668 31682 +14
==========================================
- Hits 132938 132444 -494
- Misses 36299 36907 +608
+ Partials 10751 10705 -46
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
AliasNameClient.EnumerateSubCategoriesAsync()so it follows OPC UABrowsecontinuation points until the server has returned everySubAliasNameCategoriesreference, and adds a regression test covering the paged browse case that was previously truncated after the first page.Problem
EnumerateSubCategoriesAsync()is intended to expose the full set of sub-categories organized beneath anAliasNameCategoryTypenode. However, the previous implementation only issued a singleBrowseAsync()call and immediately enumeratedBrowseResult.Referencesfrom that first response.Under OPC UA, servers are allowed to split browse results across multiple pages and return a
ContinuationPointwhen the first response does not contain the full reference set. In that situation, the client must continue withBrowseNextuntil the continuation point is exhausted. Because this helper never consumed the returned continuation point, it silently dropped every sub-category that appeared after the first page.Changes
BrowseNextAsync()whenever the initialBrowseAsync()response contains a non-empty continuation point.AliasNameCategoryTypereferences that can be resolved to localNodeIdvalues.Browse/BrowseNextsupport to the alias-name session test harness so paged browse behavior can be covered with a focused unit test.EnumerateSubCategoriesAsync()returns sub-categories from both the initial browse response and the follow-upBrowseNextresponse.