Skip to content

fix(server): enforce browse continuation point limit at capacity#4036

Merged
marcschier merged 2 commits into
OPCFoundation:masterfrom
MrAlaskan:fix/browse-continuationpoint-limit
Jul 21, 2026
Merged

fix(server): enforce browse continuation point limit at capacity#4036
marcschier merged 2 commits into
OPCFoundation:masterfrom
MrAlaskan:fix/browse-continuationpoint-limit

Conversation

@MrAlaskan

Copy link
Copy Markdown
Contributor

Fixes an off-by-one error in browse continuation-point retention by evicting the oldest point as soon as the session reaches MaxBrowseContinuationPoints, and adds a regression test covering the exact-limit case that previously allowed one extra browse continuation point to remain active.

@marcschier marcschier added the ready Ready to merge once CI Passes label Jul 19, 2026
@marcschier

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.53%. Comparing base (84fa8e8) to head (8338849).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4036      +/-   ##
==========================================
- Coverage   73.85%   73.53%   -0.33%     
==========================================
  Files        1345     1345              
  Lines      179988   180040      +52     
  Branches    31668    31679      +11     
==========================================
- Hits       132938   132397     -541     
- Misses      36299    36940     +641     
+ Partials    10751    10703      -48     
Files with missing lines Coverage Δ
...Opc.Ua.Server/Session/SessionContinuationPoints.cs 98.42% <100.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier
marcschier merged commit 1eb5e0c into OPCFoundation:master Jul 21, 2026
164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Ready to merge once CI Passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants