Skip to content

fix(server): enforce published HistoryUpdate operation limits #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcschier merged 2 commits into from
Jul 21, 2026
Merged

fix(server): enforce published HistoryUpdate operation limits #4034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d422c3d
fix(server): enforce published HistoryUpdate operation limits
MrAlaskan Jul 19, 2026
8cd7f20
Fix HistoryUpdate operation-limit regression tests
MrAlaskan Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions src/Opc.Ua.Server/Server/StandardServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,10 +1877,10 @@ public override async ValueTask<HistoryUpdateResponse> HistoryUpdateAsync(

try
{
// check only for BadNothingToDo here
// MaxNodesPerHistoryUpdateEvents & MaxNodesPerHistoryUpdateData
// must be checked in NodeManager (TODO)
ValidateOperationLimits(historyUpdateDetails);
ValidateOperationLimits(
historyUpdateDetails.Count,
GetHistoryUpdateOperationLimit(historyUpdateDetails));

(ArrayOf<HistoryUpdateResult> results, ArrayOf<DiagnosticInfo> diagnosticInfos) =
await ServerInternal.NodeManager.HistoryUpdateAsync(
Expand Down Expand Up @@ -1915,6 +1915,37 @@ await ServerInternal.NodeManager.HistoryUpdateAsync(
}
}

private PropertyState<uint>? GetHistoryUpdateOperationLimit(
ArrayOf<ExtensionObject> historyUpdateDetails)
{
foreach (ExtensionObject details in historyUpdateDetails)
{
if (details.IsNull || !details.TryGetValue(out HistoryUpdateDetails? historyUpdateDetail))
{
continue;
}

Type detailsType = historyUpdateDetail!.GetType();
if (detailsType == typeof(UpdateEventDetails) ||
detailsType == typeof(DeleteEventDetails))
{
return OperationLimits.MaxNodesPerHistoryUpdateEvents;
}

if (detailsType == typeof(UpdateDataDetails) ||
detailsType == typeof(UpdateStructureDataDetails) ||
detailsType == typeof(DeleteRawModifiedDetails) ||
detailsType == typeof(DeleteAtTimeDetails))
{
return OperationLimits.MaxNodesPerHistoryUpdateData;
}

break;
}

return null;
}

/// <inheritdoc/>
public override async ValueTask<CreateSubscriptionResponse> CreateSubscriptionAsync(
SecureChannelContext secureChannelContext,
Expand Down
86 changes: 86 additions & 0 deletions tests/Opc.Ua.History.Tests/HistoricalAccessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,92 @@ await Session.HistoryUpdateAsync(
}
}

[Test]
public async Task HistoryUpdateRejectsTooManyDataOperationsAsync()
{
NodeId nodeId = ToNodeId(Constants.ScalarStaticDouble);
var details = new ExtensionObject[1001];

for (int i = 0; i < details.Length; i++)
{
details[i] = new ExtensionObject(new UpdateDataDetails
{
NodeId = nodeId,
PerformInsertReplace = PerformUpdateType.Insert,
UpdateValues =
[
new DataValue(
new Variant((double)i),
StatusCodes.Good,
DateTime.UtcNow.AddSeconds(i))
]
});
}

uint originalDataLimit = Session.OperationLimits.MaxNodesPerHistoryUpdateData;
uint originalEventLimit = Session.OperationLimits.MaxNodesPerHistoryUpdateEvents;

try
{
// Disable client-side batching so the oversized request reaches
// the server as a single HistoryUpdate call.
Session.OperationLimits.MaxNodesPerHistoryUpdateData = 0;
Session.OperationLimits.MaxNodesPerHistoryUpdateEvents = 0;

ServiceResultException ex = Assert.ThrowsAsync<ServiceResultException>(
async () => await Session.HistoryUpdateAsync(
null,
details.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false));

Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadTooManyOperations));
}
finally
{
Session.OperationLimits.MaxNodesPerHistoryUpdateData = originalDataLimit;
Session.OperationLimits.MaxNodesPerHistoryUpdateEvents = originalEventLimit;
}
}

[Test]
public async Task HistoryUpdateRejectsTooManyEventOperationsAsync()
{
var details = new ExtensionObject[1001];

for (int i = 0; i < details.Length; i++)
{
details[i] = new ExtensionObject(new DeleteEventDetails
{
NodeId = ObjectIds.Server,
EventIds = [ByteString.From([(byte)(i & 0xff)])]
});
}

uint originalDataLimit = Session.OperationLimits.MaxNodesPerHistoryUpdateData;
uint originalEventLimit = Session.OperationLimits.MaxNodesPerHistoryUpdateEvents;

try
{
// Disable client-side batching so the oversized request reaches
// the server as a single HistoryUpdate call.
Session.OperationLimits.MaxNodesPerHistoryUpdateData = 0;
Session.OperationLimits.MaxNodesPerHistoryUpdateEvents = 0;

ServiceResultException ex = Assert.ThrowsAsync<ServiceResultException>(
async () => await Session.HistoryUpdateAsync(
null,
details.ToArrayOf(),
CancellationToken.None).ConfigureAwait(false));

Assert.That(ex.StatusCode, Is.EqualTo(StatusCodes.BadTooManyOperations));
}
finally
{
Session.OperationLimits.MaxNodesPerHistoryUpdateData = originalDataLimit;
Session.OperationLimits.MaxNodesPerHistoryUpdateEvents = originalEventLimit;
}
}

[Description("Verify that HistoryRead can read history for multiple nodes in a single request and returns one result per node.")]
[Test]
public async Task HistoryReadMultipleNodesAtOnceAsync()
Expand Down
Loading