Skip to content

[WIP] test: Update the tolerance to match other 3d comparisons #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wayfarer3130 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

[WIP] test: Update the tolerance to match other 3d comparisons #6084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tests/3DPrimary.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ test.describe('3D primary Test', async () => {

await attemptAction(() => reduce3DViewportSize(page), 10, 100);
await waitForViewportsRendered(page);
await checkForScreenshot(
await checkForScreenshot({
page,
viewportPageObject.grid,
screenShotPaths.threeDPrimary.threeDPrimaryDisplayedCorrectly
);
locator: viewportPageObject.grid,
// Volume-3D ray-cast output is GPU/driver-noisy run-to-run; match the
// tolerance already used by the sibling 3DOnly test.
maxDiffPixelRatio: 0.04,

@jbocce jbocce Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wayfarer3130 I have incorporated this into PR #6067

screenshotPath: screenShotPaths.threeDPrimary.threeDPrimaryDisplayedCorrectly,
});
});
});
Loading