Skip to content

fix: mark cohort_definition_id as primary key in cohort_definition table for v5.3 and v5.4 #787

Description

@rtmalikian

Problem

The cohort_definition_id field in the cohort_definition table is not marked as a primary key in the CSV spec files for v5.3 and v5.4, even though it is the natural primary key for that table (each cohort definition has a unique ID). The v6.0 CSV correctly marks it as a primary key.

Affected Files

  • inst/csv/OMOP_CDMv5.3_Field_Level.csvcohort_definition,cohort_definition_id has isPrimaryKey=No
  • inst/csv/OMOP_CDMv5.4_Field_Level.csv — same issue
  • docs/cdm53.html — generated HTML shows Primary Key=No
  • docs/cdm54.html — generated HTML shows Primary Key=No

Proposed Fix

Change isPrimaryKey from No to Yes for the cohort_definition_id field in the cohort_definition table in both v5.3 and v5.4 CSV files, and update the generated HTML docs accordingly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions