Skip to content

feat(HTML): replace manual XmlParser with html5ever #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
OGKevin wants to merge 3 commits into
base: ogkevin/push/xzxzsxmxvtxu
Choose a base branch
from
Draft

feat(HTML): replace manual XmlParser with html5ever #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42b5c0c
build(html): wire html parser dependencies
OGKevin Jun 11, 2026
d546a80
refactor(epub): parse OPF with roxmltree
OGKevin Jun 11, 2026
662fb82
feat(html): use html5ever source positions
OGKevin Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/build-kobo/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ inputs:
runs:
using: composite
steps:
- uses: ./.github/actions/clone-needed-cargo-submodules

- name: Cache Linaro toolchain
id: cache-linaro
uses: actions/cache@v5
Expand Down
9 changes: 9 additions & 0 deletions .github/actions/clone-needed-cargo-submodules/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
name: Clone needed Cargo submodules
description: Clone only submodules needed for Cargo manifest resolution.

runs:
using: composite
steps:
- name: Clone html5ever submodule
shell: bash
run: git submodule update --init --depth 1 thirdparty/html5ever
2 changes: 2 additions & 0 deletions .github/actions/install-doc-tools/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ inputs:
runs:
using: composite
steps:
- uses: ./.github/actions/clone-needed-cargo-submodules

- name: Setup Node.js
uses: actions/setup-node@v6
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/cadmus-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
- docs-portal/**
- crates/**/*.rs
- .github/actions/install-doc-tools/**
- .github/actions/clone-needed-cargo-submodules/**
- .github/workflows/cadmus-docs.yml
- package.json
- package-lock.json
Expand All @@ -24,6 +25,7 @@ on:
- docs-portal/**
- crates/**/*.rs
- .github/actions/install-doc-tools/**
- .github/actions/clone-needed-cargo-submodules/**
- .github/workflows/cadmus-docs.yml
- package.json
- package-lock.json
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/cargo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ on:
- ".github/actions/build-kobo/**"
- ".github/actions/build-docs-epub/**"
- ".github/actions/cargo-cache/**"
- ".github/actions/clone-needed-cargo-submodules/**"
- ".github/actions/install-doc-tools/**"
- "build-scripts/**"
- ".gitmodules"
Expand All @@ -39,6 +40,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
with:
Expand All @@ -59,6 +61,7 @@ jobs:
test-matrix: ${{ steps.matrix.outputs.test-matrix }}
steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
- name: Restore shared cargo cache
Expand Down Expand Up @@ -93,6 +96,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
with:
Expand Down Expand Up @@ -183,6 +187,7 @@ jobs:

steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
with:
Expand Down Expand Up @@ -226,6 +231,7 @@ jobs:

steps:
- uses: actions/checkout@v7
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
with:
Expand Down Expand Up @@ -270,6 +276,7 @@ jobs:
with:
fetch-depth: 0
fetch-tags: true
- uses: ./.github/actions/clone-needed-cargo-submodules
- uses: dtolnay/rust-toolchain@stable
id: rust-toolchain
- *set-build-metadata
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
pull_request:
paths:
- .github/workflows/copilot-setup-steps.yml
- .github/actions/clone-needed-cargo-submodules/**

jobs:
copilot-setup-steps:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ on:
pull_request:
paths:
- .github/workflows/release.yml
- .github/actions/build-docs-epub/**
- .github/actions/build-kobo/**
- .github/actions/cargo-cache/**
- .github/actions/clone-needed-cargo-submodules/**
- .github/actions/install-doc-tools/**

permissions:
contents: write
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@
path = thirdparty/sqlite
url = https://github.com/sqlite/sqlite
branch = version-3.49.2
[submodule "thirdparty/html5ever"]
path = thirdparty/html5ever
url = https://github.com/OGKevin/html5ever
Loading
Loading