[19.0][MIG] web_form_banner: Migration to 19.0#3309
Merged
Conversation
Refactor JS: - Switch to the ESM style - Change var to const/let - Remove unused parts (diff, el.dataset.wfbTriggerFields) Miscellaneous improvements: - list view optional - Switch archive box icon to banner Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
- Add (partial) support for elements inside groups to be a target XPath without distorting the presentation - Remove obsolete bits
AungKoKoLin1997
force-pushed
the
19.0-mig-web_form_banner
branch
from
81e8a66 to
6f32005
Compare
Contributor
Author
|
For some reason, the demo data are not being loaded in runboat and CI tests. |
Member
|
@AungKoKoLin1997 Can we switch to not relying on demo data for tests? |
- Fix not updating banner when pager is update or duplicate or create - Fix presentation of help in web form banner rule
AungKoKoLin1997
force-pushed
the
19.0-mig-web_form_banner
branch
2 times, most recently
from
1dcf04d to
e728acd
Compare
yostashiro
reviewed
Oct 21, 2025
AungKoKoLin1997
force-pushed
the
19.0-mig-web_form_banner
branch
from
e728acd to
e929e76
Compare
yostashiro
reviewed
Oct 22, 2025
AungKoKoLin1997
force-pushed
the
19.0-mig-web_form_banner
branch
from
e929e76 to
ae7c091
Compare
yostashiro
approved these changes
Oct 22, 2025
yostashiro
left a comment
yostashiro
left a comment
Member
There was a problem hiding this comment.
Code review and functional test. LGTM. 👍
6 tasks
Member
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 04d2033. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #3308
The module adds configurable banners for backend form views. Define rules per model
(and optionally per view) to show context-aware alerts with a chosen severity (info/warning/danger).
Messages can be plain text with ${placeholders} or fully custom HTML; visibility,
severity, and values are computed server-side via a safe Python expression.
Banners are injected just before or after a target node (default: //sheet) and refresh
on form load/save/reload.
@qrtl QT5747