[19.0][MIG] fetchmail_thread_default - #1898
Open
KKamaa wants to merge 43 commits into
Open
Conversation
This addon lets the sysadmin choose a default mail thread sink for incoming mails. You can use it to forward all unbound incoming emails to a `mail.channel` where only certain users are subscribed and can triage them.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-fetchmail_thread_default/
On fetchmail_thread_default when creating a new mail.message it says the context["fetchmail_server_id"] is None, the field value is context["default_fetchmail_server_id"].
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-14.0/social-14.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-fetchmail_thread_default/
Currently translated at 12.5% (1 of 8 strings) Translation: social-14.0/social-14.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-fetchmail_thread_default/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-fetchmail_thread_default/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-fetchmail_thread_default/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-fetchmail_thread_default/it/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-fetchmail_thread_default/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-fetchmail_thread_default/it/
Currently translated at 100.0% (4 of 4 strings) Translation: social-18.0/social-18.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-18-0/social-18-0-fetchmail_thread_default/es/
Currently translated at 100.0% (4 of 4 strings) Translation: social-18.0/social-18.0-fetchmail_thread_default Translate-URL: https://translation.odoo-community.org/projects/social-18-0/social-18-0-fetchmail_thread_default/sl/
OCA-git-bot
added
mod:fetchmail_thread_default
Kiplangatdan
approved these changes
Aug 10, 2026
thomaspaulb
approved these changes
Aug 10, 2026
|
@OCA/social-maintainers |
thomaspaulb
changed the title
|
/ocabot migration fetchmail_thread_default |
Contributor
|
This PR has the |
NL66278
reviewed
Aug 11, 2026
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| { | ||
| "name": "Default Thread For Unbounded Emails", | ||
| "summary": "Post unkonwn messages to an existing thread", |
NL66278
reviewed
Aug 11, 2026
| strip_attachments=False, | ||
| thread_id=None, | ||
| ): | ||
| server = self.env["fetchmail.server"].browse( |
There was a problem hiding this comment.
This is only needed when either model or thread_id are not set. So in many cases the browse action will be done for no purpose. Better to split the if condition like so:
if not (model or thread_id):
server = self.env["fetchmail.server"].browse(
self.env.context.get("default_fetchmail_server_id")
)
if server.default_thread_id:
model = server.default_thread_id._name
thread_id = server.default_thread_id.id
I kept the not (model or thread_id) but I wonder whether this is correct. A thread_id with no model does not make sense. But a model with thread_id filled will lead to creation of a new record in the model. We can assume no thread_id is passed without a model, but the following condition should be enough: if not model.
NL66278
reviewed
Aug 11, 2026
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
👍 No really blocking issues, but if you could take up my comments, that would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.