Skip to content

[18.0][ADD] purchase_report_discount_visibility#94

Open
AungKoKoLin1997 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-purchase_report_discount_visibility
Open

[18.0][ADD] purchase_report_discount_visibility#94
AungKoKoLin1997 wants to merge 1 commit into
OCA:18.0from
qrtl:18.0-add-purchase_report_discount_visibility

Conversation

@AungKoKoLin1997

Copy link
Copy Markdown
Contributor

This module allows hiding the Discount column in the Purchase Order report, either always or only when all order lines have no discount.

@qrtl QT6324

Comment thread purchase_report_discount_visibility/models/res_company.py Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-purchase_report_discount_visibility branch from 48a207b to 3241ce9 Compare January 15, 2026 01:41
Comment thread purchase_report_discount_visibility/models/purchase_order.py Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-purchase_report_discount_visibility branch from 3241ce9 to e65b82a Compare January 15, 2026 02:59

@yostashiro yostashiro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was necessarily a good move to move the logic from Python to the template, but it's trivial. LGTM.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-purchase_report_discount_visibility branch from e65b82a to 95a5e31 Compare January 15, 2026 04:53
Comment thread purchase_report_discount_visibility/report/purchase_report_templates.xml Outdated
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 18.0-add-purchase_report_discount_visibility branch from 95a5e31 to 6470472 Compare January 15, 2026 05:45

@kanda999 kanda999 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as draft May 19, 2026 01:17
@AungKoKoLin1997 AungKoKoLin1997 marked this pull request as ready for review May 25, 2026 01:30

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM!

@HviorForgeFlow

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-94-by-HviorForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@HviorForgeFlow The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_purchase_report_discount_visibility-18.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_purchase_report_discount_visibility-18.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests                                                      

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants