[MIG] sale_report_margin: Migration to 19.0 - #281
Open
dreispt wants to merge 25 commits into
Open
Conversation
[FIX] sale_report_margin: website attribute in manifest
Currently translated at 100.0% (2 of 2 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_report_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_report_margin/es/
Currently translated at 100.0% (2 of 2 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_report_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_report_margin/it/
Port sale_report_margin from 18.0 to 19.0. Assisted-by: Devin:SWE-1.7 Medium
carlos-lopez-tecnativa
suggested changes
Aug 25, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but if you can squash the administrative commits and apply my suggestion, that would be great.
TT64206
| from odoo.tests.common import TransactionCase | ||
|
|
||
|
|
||
| class TestSaleReportMargin(TransactionCase): |
Contributor
There was a problem hiding this comment.
Could you inherit from BaseCommon?
Suggested change
| class TestSaleReportMargin(TransactionCase): | |
| class TestSaleReportMargin(BaseCommon): |
Comment on lines
+23
to
+26
| ( | ||
| 0, | ||
| 0, | ||
| { |
Contributor
There was a problem hiding this comment.
Suggested change
| ( | |
| 0, | |
| 0, | |
| { | |
| Command.create( | |
| { |
| cls.product_product = cls.env["product.product"].create( | ||
| {"name": "Product Test"} | ||
| ) | ||
| cls.partner = cls.env["res.partner"].create({"name": "Partner Test"}) |
Contributor
There was a problem hiding this comment.
Inherited from BaseCommon, we already have a partner, so I think this is not necessary.
Suggested change
| cls.partner = cls.env["res.partner"].create({"name": "Partner Test"}) |
manuelcalerosolis
added a commit
to xtendoo-corporation/xtendoo
that referenced
this pull request
Aug 26, 2026
OCA no mantiene estos 8 módulos que DJI usa en 19.0 (no existe rama 19.0 en sus repos), pero cada uno tiene un Pull Request abierto (sin fusionar) que sí los migra. Decisión del usuario: usar esos PRs en vez de forkear desde cero. Renombrados con prefijo xtendoo_ para evitar colisión de nombre técnico si OCA fusiona el PR original más adelante. - xtendoo_web_company_color <- OCA/web#3326 (HeliconiaIO/web) - xtendoo_hr_expense_cancel <- OCA/hr-expense#356 (ledoent/hr-expense) - xtendoo_hr_expense_payment <- OCA/hr-expense#355 (ledoent/hr-expense) - xtendoo_website_whatsapp <- OCA/website#1207 (Jarsa-dev/website) - xtendoo_stock_picking_mass_action <- OCA/stock-logistics-workflow#2161 (adhoc-dev/stock-logistics-workflow) - xtendoo_sale_report_margin <- OCA/margin-analysis#281 (ursais/margin-analysis) - xtendoo_product_pricelist_direct_print <- OCA/product-attribute#2220 (Studio73/product-attribute) - xtendoo_account_move_line_stock_info <- OCA/stock-logistics-warehouse#2549 (collinskipkorir/stock-logistics-warehouse) - version bump 18.0->19.0 aplicado a mano, el PR original no lo traía Además de renombrar directorio/manifest, corregidas referencias técnicas reales que dependían del nombre del módulo (no solo cosméticas): report_name/t-call/env.ref en product_pricelist_direct_print, ir.model. access.csv + view id en stock_picking_mass_action, ruta de assets estáticos en website_whatsapp (URL /website_whatsapp/static/... hubiera dado 404), e imports de tests/__init__.py tras renombrar los ficheros de test. 3 módulos descontinuados (website_sale_product_description, stock_picking_warn_message, account_payment_order_return) NO se implantan en 19.0, decisión explícita del usuario.
Contributor
|
ping @dreispt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #259