[17.0][FIX] hr_course: show results on completed schedules#1593
Open
miquelrosell99 wants to merge 2 commits into
Open
[17.0][FIX] hr_course: show results on completed schedules#1593miquelrosell99 wants to merge 2 commits into
miquelrosell99 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Once a course schedule reaches the "completed" state, the Course Results page is visible but empty because the attendee list is only shown in the "in_validation" state.
Fix: Show the attendee results list whenever the Course Results page is visible (in_progress, in_validation, completed) and make it editable only during validation.
Also fixes a minor bug in
validation2complete()whereselfwas used instead ofrecordinside the loop, so pending results were not checked per record when completing multiple schedules at once.Test added for the multi-record case.