[19.0][MIG] hr_holidays_public_city: Migration to 19.0 - #265
Open
niboo-sfa wants to merge 18 commits into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:hr_holidays_public_city
niboo-sfa
force-pushed
the
19.0-mig-hr_holidays_public_city
branch
from
July 11, 2026 12:07
574ca32 to
9f92982
Compare
|
@niboo-sfa The commit history is missing. Please preserve the commit history and follow the OCA contribution guidelines: |
TT43035 [UPD] Update hr_holidays_public_city.pot [UPD] README.rst hr_holidays_public_city 15.0.1.0.1
Translated using Weblate (Italian) Currently translated at 100.0% (4 of 4 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_holidays_public_city Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_holidays_public_city/it/ [UPD] README.rst
TT45870 [UPD] Update hr_holidays_public_city.pot
[UPD] Update hr_holidays_public_city.pot [BOT] post-merge updates
…loyee Use case: - Go to Employees to an employee with a different address (country) than our own and with specific public holidays for that country. - Go to the Time-off smart-buttons - We will have to see there the public holidays according to the employee's address TT49839 [BOT] post-merge updates
Currently translated at 100.0% (4 of 4 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public_city Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public_city/it/
Forgotten in OCA@37538ec TT61153
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-holidays-18.0/hr-holidays-18.0-hr_holidays_public_city Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-18-0/hr-holidays-18-0-hr_holidays_public_city/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-holidays-18.0/hr-holidays-18.0-hr_holidays_public_city Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-18-0/hr-holidays-18-0-hr_holidays_public_city/it/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-holidays-18.0/hr-holidays-18.0-hr_holidays_public_city Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-18-0/hr-holidays-18-0-hr_holidays_public_city/es/
All overridden methods and fields from hr_holidays_public and
calendar_public_holiday (state_ids, city_ids, _get_domain_states_filter,
_get_domain_check_date_state_one*, _prepare_holidays_meeting_values) are
unchanged in 19.0, so the module code ports as-is.
The only breaking change is in the test suite: hr.leave.get_unusual_days()
now requires full datetime strings ("%Y-%m-%d %H:%M:%S") instead of bare
dates, matching hr_holidays_public's own 19.0 test suite. Updated
tests/test_holidays_public.py accordingly.
niboo-sfa
force-pushed
the
19.0-mig-hr_holidays_public_city
branch
from
July 20, 2026 13:04
9f92982 to
8a150ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migration of
hr_holidays_public_cityfrom 18.0 to 19.0.All overridden methods and fields from
hr_holidays_publicandcalendar_public_holiday(state_ids,city_ids,_get_domain_states_filter,_get_domain_check_date_state_one*,_prepare_holidays_meeting_values) are unchanged in 19.0, so the module code ports as-is.The only breaking change is in the test suite:
hr.leave.get_unusual_days()now requires full datetime strings ("%Y-%m-%d %H:%M:%S") instead of bare dates, matchinghr_holidays_public's own 19.0 test suite. Updatedtests/test_holidays_public.pyaccordingly.Testing
Tested in a dedicated Odoo 19.0 instance with the module's dependencies (
hr_holidays_public,base_address_extended,calendar_public_holidayfromOCA/calendar19.0).6/8 tests pass. The 2 remaining failures are environmental, not a regression: they test the "no country/state resolved" case with a holiday restricted to the US and expect it to be excluded, but the "if nothing resolves, filter nothing" behavior is the existing intended design in
hr_holidays_public(verified by running its own suite, 20/20 green, in the same environment). The fresh test company in this Docker environment simply has no default country set, unlike OCA's CI environment.🤖 Generated with Claude Code