Skip to content

[ADD] hr_holidays_public_project_timesheet_holidays - #261

Open
gurneyalex wants to merge 1 commit into
OCA:19.0from
camptocamp:19.0-hr_holidays_public_project_timesheet_holidays
Open

[ADD] hr_holidays_public_project_timesheet_holidays#261
gurneyalex wants to merge 1 commit into
OCA:19.0from
camptocamp:19.0-hr_holidays_public_project_timesheet_holidays

Conversation

@gurneyalex

@gurneyalex gurneyalex commented Jun 24, 2026

Copy link
Copy Markdown
Member

Glue module between hr_holidays_public and project_timesheet_holidays

@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_holidays_public_project_timesheet_holidays Module hr_holidays_public_project_timesheet_holidays labels Jun 24, 2026
@gurneyalex
gurneyalex marked this pull request as draft June 24, 2026 06:20
@gurneyalex
gurneyalex marked this pull request as ready for review June 26, 2026 05:42
vvrossem
vvrossem reviewed Jun 26, 2026
View reviewed changes

@vvrossem vvrossem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prepend # Copyright 2026 Camptocamp SA to .py files

Comment thread hr_holidays_public_project_timesheet_holidays/__manifest__.py Outdated
Comment thread hr_holidays_public_project_timesheet_holidays/__manifest__.py Outdated
Comment thread hr_holidays_public_project_timesheet_holidays/__manifest__.py Outdated
Comment thread hr_holidays_public_project_timesheet_holidays/models/calendar_public_holiday_line.py Outdated
ivantodorovich
ivantodorovich approved these changes Jun 29, 2026
View reviewed changes

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Since it's already approved, could you squash the fixup commits so they don't get merged like this by mistake 🙏🏻 ?

Comment thread hr_holidays_public_project_timesheet_holidays/models/calendar_public_holiday_line.py
Comment on lines +52 to +54
employees_by_partner = defaultdict(lambda: self.env["hr.employee"])
for employee in employees:
employees_by_partner[employee.address_id.id] |= employee

@ivantodorovich ivantodorovich Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
employees_by_partner = defaultdict(lambda: self.env["hr.employee"])
for employee in employees:
employees_by_partner[employee.address_id.id] |= employee
employees_by_partner = employees.grouped("address_id")

💡 tip: not blocking, just sharing

@OCA-git-bot

OCA-git-bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@gurneyalex
[ADD] hr_holidays_public_project_timesheet_holidays
83761cd 
Glue module between hr_holidays_public and project_timesheet_holidays
@gurneyalex
gurneyalex force-pushed the 19.0-hr_holidays_public_project_timesheet_holidays branch from 5e03861 to 83761cd Compare July 7, 2026 13:40
@gurneyalex

gurneyalex commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-261-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@gurneyalex The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_hr_holidays_public_project_timesheet_holidays-19.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_hr_holidays_public_project_timesheet_holidays-19.0.1.0.0.2-py3-none-a
ny.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@gurneyalex

gurneyalex commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-261-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@gurneyalex The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_hr_holidays_public_project_timesheet_holidays-19.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_hr_holidays_public_project_timesheet_holidays-19.0.1.0.0.2-py3-none-a
ny.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@vvrossem vvrossem vvrossem left review comments
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@wouitmil wouitmil wouitmil approved these changes
@PaoloYam PaoloYam PaoloYam approved these changes
@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:hr_holidays_public_project_timesheet_holidays Module hr_holidays_public_project_timesheet_holidays ready to merge series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gurneyalex @OCA-git-bot @ivantodorovich @wouitmil @vvrossem @PaoloYam @BhaveshHeliconia