Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions hr_holidays_approval_split/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
=======================
Time Off Approval Split
=======================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:7c25656dd529c1d0649bd3ed106831090c04f8e8dee7e83c0f420977219b59b5
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fhr--holidays-lightgray.png?logo=github
:target: https://github.com/OCA/hr-holidays/tree/17.0/hr_holidays_approval_split
:alt: OCA/hr-holidays
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_approval_split
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/hr-holidays&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module introduces a new field validation_type_split in Time Off
Types to define whether approval is required for hour-based requests,
day-based requests, or both.

**Table of contents**

.. contents::
:local:

Usage
=====

1. create a Time Off request using a Time Off Type that requires
validation by an Officer.
2. Depending on the value selected in the Approval Type field, the
system will determine whether approval is required for hour-based or
day-based requests.
3. If the request type does not require approval according to this
configuration, the leave will be automatically confirmed and
validated.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr-holidays/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/hr-holidays/issues/new?body=module:%20hr_holidays_approval_split%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
-------

* ForgeFlow

Contributors
------------

- `ForgeFlow <https://www.forgeflow.com>`__:

- Guillermo Navas <guillermo.navas@forgeflow.com>

Maintainers
-----------

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/hr-holidays <https://github.com/OCA/hr-holidays/tree/17.0/hr_holidays_approval_split>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions hr_holidays_approval_split/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
21 changes: 21 additions & 0 deletions hr_holidays_approval_split/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Copyright 2026 ForgeFlow S.L. (https://www.forgeflow.com)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
{
"name": "Time Off Approval Split",
"summary": """
Allow configuring approval requirements separately for hour-based and
day-based time off requests.
""",
"category": "Human Resources/Time Off",
"version": "17.0.1.0.0",
"license": "AGPL-3",
"author": "ForgeFlow, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/hr-holidays",
"contributors": [
"Guillermo Navas <guillermo.navas@forgeflow.com>",
],
"depends": ["hr_holidays"],
"data": [
"views/hr_leave_type_views.xml",
],
}
2 changes: 2 additions & 0 deletions hr_holidays_approval_split/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import hr_leave_type
from . import hr_leave
41 changes: 41 additions & 0 deletions hr_holidays_approval_split/models/hr_leave.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
from odoo import _, api, models


class HolidaysRequest(models.Model):
_inherit = "hr.leave"

@api.model_create_multi
def create(self, vals_list):
holidays = super().create(vals_list)

auto_validate = holidays.filtered(
Comment thread
GuillermoNforgeflow marked this conversation as resolved.
lambda h: (
h.holiday_status_id.leave_validation_type != "no_validation"
and (
(
h.holiday_status_id.validation_type_split == "hours"
and not h.request_unit_hours
and not h.request_unit_half
)
or (
h.holiday_status_id.validation_type_split == "days"
and (h.request_unit_hours or h.request_unit_half)
)
)
)
)
Comment thread
GuillermoNforgeflow marked this conversation as resolved.

for holiday in auto_validate:
# As done in core, we use sudo() as the user might not have the
# rights when creating the leave
# https://github.com/odoo/odoo/blob/97b60952d59a57aba12b048cb4da4f41d85d2ea2/addons/hr_holidays/models/hr_leave.py#L978-L980
holiday.sudo().action_validate()
holiday.sudo().message_subscribe(
partner_ids=holiday._get_responsible_for_approval().partner_id.ids
)
holiday.sudo().message_post(
body=_("The time off has been automatically approved"),
subtype_xmlid="mail.mt_comment",
)
Comment thread
GuillermoNforgeflow marked this conversation as resolved.

return holidays
19 changes: 19 additions & 0 deletions hr_holidays_approval_split/models/hr_leave_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
from odoo import fields, models


class HrLeaveType(models.Model):
_inherit = "hr.leave.type"

validation_type_split = fields.Selection(
[
("both", "Hours and Days require approval"),
("hours", "Only Hours require approval"),
("days", "Only Days require approval"),
],
string="Approval Type",
default="both",
help="""
Define whether approval is required for hour-based requests,
day-based requests or both.
""",
)
Comment thread
GuillermoNforgeflow marked this conversation as resolved.
3 changes: 3 additions & 0 deletions hr_holidays_approval_split/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
2 changes: 2 additions & 0 deletions hr_holidays_approval_split/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ForgeFlow](https://www.forgeflow.com):
- Guillermo Navas \<<guillermo.navas@forgeflow.com>\>
3 changes: 3 additions & 0 deletions hr_holidays_approval_split/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This module introduces a new field validation_type_split in Time Off Types
to define whether approval is required for hour-based requests, day-based
requests, or both.
5 changes: 5 additions & 0 deletions hr_holidays_approval_split/readme/USAGE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
1. create a Time Off request using a Time Off Type that requires validation by an Officer.
2. Depending on the value selected in the Approval Type field, the system will determine
whether approval is required for hour-based or day-based requests.
3. If the request type does not require approval according to this configuration, the leave
will be automatically confirmed and validated.
Loading
Loading