[19.0][MIG] hr_expense_sequence: Migration to 19.0 - #353
Open
dnplkndll wants to merge 36 commits into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:hr_expense_sequence
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
from
May 26, 2026 23:37
7cd28b5 to
0473f31
Compare
dnplkndll
marked this pull request as draft
May 27, 2026 00:15
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
2 times, most recently
from
May 29, 2026 15:31
bcbf310 to
bff17b0
Compare
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Currently translated at 100.0% (3 of 3 strings) Translation: hr-10.0/hr-10.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-10-0/hr-10-0-hr_expense_sequence/de/
Currently translated at 100.0% (3 of 3 strings) Translation: hr-expense-14.0/hr-expense-14.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-14-0/hr-expense-14-0-hr_expense_sequence/pt_BR/
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
2 times, most recently
from
May 30, 2026 14:55
d415fb2 to
f6bf345
Compare
dnplkndll
marked this pull request as ready for review
May 30, 2026 15:19
| /> | ||
| <field name="arch" type="xml"> | ||
| <field name="name" position="before"> | ||
| <field name="number" /> |
Contributor
There was a problem hiding this comment.
Why aren't we adding this field to the form view?
Comment on lines
+14
to
+15
| # Create our own product fixture — OCA CI runs without demo data so | ||
| # `product.product_product_4` is not available. |
Contributor
There was a problem hiding this comment.
Suggested change
| # Create our own product fixture — OCA CI runs without demo data so | |
| # `product.product_product_4` is not available. |
Could we remove this unnecessary comment?
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
from
June 2, 2026 17:46
f6bf345 to
5c23b75
Compare
BhaveshHeliconia
approved these changes
Jun 3, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
5 times, most recently
from
June 19, 2026 19:12
de2bfb9 to
f165570
Compare
Contributor
|
Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
Currently translated at 100.0% (3 of 3 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_sequence/it/
Currently translated at 100.0% (3 of 3 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_sequence/it/
Currently translated at 100.0% (3 of 3 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_sequence/it/
Currently translated at 100.0% (2 of 2 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_sequence/es/
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
from
June 22, 2026 17:57
f165570 to
b0e3b46
Compare
Currently translated at 100.0% (2 of 2 strings) Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_sequence Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_sequence/sl/
Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
from
July 27, 2026 17:43
b0e3b46 to
da86fb4
Compare
hr.expense.sheet was removed in 19.0; retarget the sequence and number field from the expense sheet to the individual hr.expense record. - The shipped sequence keeps its 18.0 code and name (hr.expense.sheet / "Expense report sequence"), even though the string names a model that no longer exists. The data file is noupdate="1", so a database upgraded from 18.0 keeps the record as created; renaming it here would leave those databases without a sequence to draw from and every expense would keep the "/" placeholder. A test pins the code to the shipped record. Assisted-by: Claude Opus 5
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence
branch
from
July 27, 2026 17:44
da86fb4 to
49b1a90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
hr_expense_sequencefrom 18.0 to 19.0 (migration guide).Non-mechanical adaptations worth flagging
_inherit = "hr.expense.sheet"→_inherit = "hr.expense". ThenumberChar + auto-sequence-in-create()logic moves tohr.expenseitself, and_rec_name = "number"follows.hr.expense.sheet/ Expense report sequence), even though the string names a model that no longer exists. The data file isnoupdate="1", so a database upgraded from 18.0 keeps the record as created; renaming it would leave those databases without a sequence to draw from and every expense would keep the/placeholder. A test pins the code to the shipped record. Happy to swap this for a rename plus a migration script if maintainers prefer that direction.hr_expense.hr_expense_view_form/hr_expense_view_expenses_analysis_tree/hr_expense_view_search(the 18.0 sheet view IDs are gone).numberis on both the list and the form.hr_expense.report_expense(wasreport_expense_sheet).post_init_hook: backfill now iterateshr.expenserecords (not sheets); same sequence-pull pattern.hr.expense.create()with explicit / auto / manual-override paths..pot/.poregeneration in this PR, so Weblate contributions (including the Slovenian and Turkish files) survive the port untouched.AI-assisted (Claude Code); every change reviewed, tested, and owned by the author.