Skip to content

[19.0[IMP] edi_core_oca: mark process integrity errors as failed #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yankinmax wants to merge 1 commit into
base: 19.0
Choose a base branch
from
+40 −9
Open

[19.0[IMP] edi_core_oca: mark process integrity errors as failed #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions edi_core_oca/models/edi_backend.py
View file
Open in desktop
Comment thread
yankinmax marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -297,12 +297,19 @@ def exchange_send(self, exchange_record):
return res

def _swallable_exceptions(self):
# TODO: improve this list
# These errors are permanent because retrying the same data will fail again.
# They should be swallowed so the exchange can move to an error state.
#
# SQL errors are handled separately: OperationalError may be transient,
# while IntegrityError requires process-specific transaction handling.
return (
ValueError,
FileNotFoundError,
exceptions.UserError,
exceptions.ValidationError,
TypeError,
LookupError, # covers KeyError / IndexError
AttributeError,
)

def _send_retryable_exceptions(self):
Expand Down Expand Up @@ -486,7 +493,14 @@ def exchange_process(self, exchange_record):
error = _get_exception_msg(err)
state = "input_processed_error"
res = f"Error: {error}"
except (OperationalError, IntegrityError):
except IntegrityError as err:
Comment on lines 495 to +496

@Ricardoalso Ricardoalso Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well with this change we just end up duplicating code

if self.env.context.get("_edi_process_break_on_error"):
    raise
traceback = _get_exception_traceback()
error = _get_exception_msg(err)
state = "input_processed_error"
res = f"Error: {error}"

I rechecked the code and with the changes introduced by 8f44487,
I would keep IntegrityError inside _swallable_exceptions because it always runs inside a cr.savepoint(), which rolls back to the savepoint before this is caught, leaving the cursor usable.

Leaving OperationalError handling (res = "__sql_error__") separately as it may indicate a broken connection rather than a "bad statement".

@guewen your input is welcome on this one 🙏

if self.env.context.get("_edi_process_break_on_error"):
raise
traceback = _get_exception_traceback()
error = _get_exception_msg(err)
state = "input_processed_error"
res = f"Error: {error}"
except OperationalError:
# We don't want the finally block to be executed in this case as
# the cursor is already in an aborted state and any query will fail.
res = "__sql_error__"
Expand Down
31 changes: 24 additions & 7 deletions edi_core_oca/tests/test_backend_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import base64

from freezegun import freeze_time
from psycopg2 import IntegrityError

from odoo import fields
from odoo.exceptions import UserError
Expand Down Expand Up @@ -110,13 +109,31 @@ def test_process_outbound_record(self):
with self.assertRaises(UserError):
record.action_exchange_process()

@mute_logger("odoo.sql_db")
def test_process_record_with_integrity_error(self):
conflicting_record = self.backend.create_record(
"test_csv_input",
{
"model": self.partner._name,
"res_id": self.partner.id,
"exchange_file": base64.b64encode(b"1234"),
},
)
original_identifier = self.record.identifier
duplicate_identifier = conflicting_record.identifier
self.record.write({"edi_exchange_state": "input_received"})
with self.assertRaises(IntegrityError):
self.backend.with_context(
test_break_process=IntegrityError("SQL error")
).exchange_process(self.record)
self.assertRecordValues(self.record, [{"edi_exchange_state": "input_received"}])
self.assertFalse(self.record.exchange_error)

self.record.with_context(
fake_update_values={"identifier": duplicate_identifier}
).action_exchange_process()
self.assertRecordValues(
self.record,
[
{
"identifier": original_identifier,
"edi_exchange_state": "input_processed_error",
}
],
)

# TODO: test ack file are processed
Loading