[18.0][FIX] sale_financial_risk: avoid writing on commercial_partner during compute on partner - #536
Open
clementmbr wants to merge 1 commit into
Open
[18.0][FIX] sale_financial_risk: avoid writing on commercial_partner during compute on partner#536clementmbr wants to merge 1 commit into
clementmbr wants to merge 1 commit into
Conversation
2 tasks
|
Why is it writing on commercial_partner_id upon read? the field is stored IMO previous code was ok |
cyrilmanuel
approved these changes
Mar 12, 2026
pedrobaeza
requested changes
Mar 12, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
This is needed since this change:
and being non stored, it's not a problem.
Please indicate which is the specific problem you want to fix.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Odoo is writing on a commercial_partner when doing
_compute_risk_sale_order()on a partner (two different records).It is against the expected behavior of a non-stored readonly computed field and can create security problems as the commercial_partner record is not necessary accessible by the Odoo user who is accessing the current partner's record.
cc @sebastienbeau