Skip to content

Fix ScdFile#GetAudio for OGG files #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NotAdam merged 2 commits into from
Jul 20, 2026
Merged

Fix ScdFile#GetAudio for OGG files #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271a33e
Fix parsing ogg audio data
RajahOmen Jul 15, 2026
abee55c
formatting
RajahOmen Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Lumina.Tests/LuminaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Lumina.Data.Files;
using Xunit;

namespace Lumina.Tests;
Expand All @@ -18,4 +19,20 @@ public void FilePathsAreParsedCorrectly( string category, string repo, ulong has
Assert.Equal( repo, parsed.Repository );
Assert.Equal( hash, parsed.IndexHash );
}

[RequiresGameInstallationFact]
public void ScdFilesAreLoadedCorrectly()
{
var gameData = RequiresGameInstallationFact.CreateGameData();
var file = gameData.GetFile<ScdFile>( "music/ex1/bgm_ex1_alex01.scd" );

Assert.NotNull( file );
Assert.NotEmpty( file.Data );
Assert.True( file.AudioDataCount > 0 );
Assert.NotNull( file.GetAudio( 0 ) );
Assert.True( file.SoundDataCount > 0 );
Assert.NotNull( file.GetSound( 0 ) );
Assert.True( file.TrackDataCount > 0 );
Assert.NotNull( file.GetTrack( 0 ) );
}
}
2 changes: 1 addition & 1 deletion src/Lumina/Data/Files/ScdFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ public Audio GetAudio( int index )
audio.AudioDataHeader = oggSeekTableHeader;
audio.SeekTable = Reader.ReadUInt32Array( (int)( oggSeekTableHeader.SeekTableSize / 4 ) );

Reader.Position = subInfoStartPos + audioBasicDesc.SubInfoSize;
Reader.Position = subInfoStartPos + audioBasicDesc.SubInfoSize - oggSeekTableHeader.OggHeaderSize;

var oggFile = new byte[ oggSeekTableHeader.OggHeaderSize + audioBasicDesc.Size ];
Array.Copy( Reader.ReadBytes( (int)oggSeekTableHeader.OggHeaderSize ), oggFile, oggSeekTableHeader.OggHeaderSize );
Expand Down
Loading