Skip to content

poppler: remove poppler_gi variant - #223577

Closed
Artturin wants to merge 1 commit into
NixOS:stagingfrom
Artturin:removepopplergi
Closed

poppler: remove poppler_gi variant#223577
Artturin wants to merge 1 commit into
NixOS:stagingfrom
Artturin:removepopplergi

Conversation

@Artturin

@Artturin Artturin commented Mar 28, 2023

Copy link
Copy Markdown
Member

there's no need to have a separate attr for a gi poppler

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: python Python is a high-level, general-purpose programming language. labels Mar 28, 2023
SuperSandro2000
SuperSandro2000 reviewed Mar 28, 2023
View reviewed changes
Comment thread pkgs/development/haskell-modules/hackage-packages.nix Outdated

@SuperSandro2000 SuperSandro2000 Mar 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NixOS/haskell does this need some update in the tooling?

@sternenseemann sternenseemann Mar 28, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NixOS/cabal2nix/blob/4541e7090bd30063db086e6e9c3dc1dbcf8526a8/cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/Name.hs#L142

@ofborg ofborg Bot added the 8.has: clean-up This PR removes packages or removes other cruft label Mar 28, 2023
@ofborg ofborg Bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 28, 2023
@jtojnar

jtojnar commented Mar 28, 2023

Copy link
Copy Markdown
Member

Poppler actually consists of three (or four) different libraries: the native C++ API, GObject-based API and Qt-based API. gobject-introspection only really makes sense for the GObject API. Ideally, we would have packages that are non-overlapping.

@Artturin
poppler: remove poppler_gi variant
4fbffe0 
there's no need to have a separate attr for a gi poppler
Artturin added a commit to Artturin/cabal2nix that referenced this pull request Apr 3, 2023
@Artturin
cabal2nix: update attr for poppler-glib after the poppler_gi variant …
94f2c94 
…is removed

NixOS/nixpkgs#223577
@Artturin Artturin mentioned this pull request Apr 3, 2023
Draft
@Artturin

Artturin commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

Added && suffix == "glib" to withIntrospection

pr to cabal2nix NixOS/cabal2nix#599

@Artturin
Artturin marked this pull request as ready for review April 3, 2023 21:27
jtojnar
jtojnar reviewed Apr 3, 2023
View reviewed changes
Comment thread pkgs/top-level/all-packages.nix
@@ -23089,10 +23089,6 @@ with pkgs;

poppler = callPackage ../development/libraries/poppler { lcms = lcms2; };

@jtojnar jtojnar Apr 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name this poppler-glib then.

jtojnar
jtojnar reviewed Apr 3, 2023
View reviewed changes
Comment thread pkgs/development/libraries/poppler/default.nix
# TODO: REMOVE
gobject-introspection
];

@jtojnar jtojnar Apr 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And change to only build GLIB in cmakeFlags when suffix is glib here.

@ofborg
ofborg Bot requested a review from jtojnar April 3, 2023 23:22
@ofborg ofborg Bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Apr 3, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@stale stale Bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@Artturin Artturin closed this Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann left review comments
@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments
@dotlambda dotlambda Awaiting requested review from dotlambda
@tbenst tbenst Awaiting requested review from tbenst
@flokli flokli Awaiting requested review from flokli
@symphorien symphorien Awaiting requested review from symphorien
@aszlig aszlig Awaiting requested review from aszlig
@ttuegel ttuegel Awaiting requested review from ttuegel
@cdepillabout cdepillabout Awaiting requested review from cdepillabout
@maralorn maralorn Awaiting requested review from maralorn
@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Artturin @jtojnar @sternenseemann @SuperSandro2000 @wegank