Fix #5490 - E+ 25.2.0: Wrap HeatPump:AirToWater

src/energyplus/ForwardTranslator.cpp

@@ -1958,6 +1958,16 @@ namespace energyplus {
         retVal = translateHeatPumpAirToWater(mo);
         break;
       }
+      case openstudio::IddObjectType::OS_HeatPump_AirToWater_Cooling: {
+        // no-op, just Log a Trace message
+        LOG(Trace, "HeatPumpAirToWaterCooling is not translated by itself but in the parent HeatPumpAirToWater");
+        break;
+      }
+      case openstudio::IddObjectType::OS_HeatPump_AirToWater_Heating: {
+        // no-op, just Log a Trace message
+        LOG(Trace, "HeatPumpAirToWaterHeating is not translated by itself but in the parent HeatPumpAirToWater");
+        break;
+      }
       case openstudio::IddObjectType::OS_HeatPump_AirToWater_FuelFired_Heating: {
         auto mo = modelObject.cast<HeatPumpAirToWaterFuelFiredHeating>();
         retVal = translateHeatPumpAirToWaterFuelFiredHeating(mo);

src/model/HeatPumpAirToWater.cpp

@@ -470,19 +470,27 @@ namespace model {
     }
 
     boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedAirFlowRateinHeatingMode() const {
-      return getAutosizedValue("Design Size Source Side Volume Flow Rate", "m3/s", "HeatPump:AirToWater:Heating");
+      return getAutosizedValue("Design Size Rated Air Volume Flow Rate in Heating Mode", "m3/s");
     }
 
     boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedWaterFlowRateinHeatingMode() const {
-      return getAutosizedValue("Design Size Load Side Volume Flow Rate", "m3/s", "HeatPump:AirToWater:Heating");
+      return getAutosizedValue("Design Size Rated Water Volume Flow Rate in Heating Mode", "m3/s");
     }
 
     boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedAirFlowRateinCoolingMode() const {
-      return getAutosizedValue("Design Size Source Side Volume Flow Rate", "m3/s", "HeatPump:AirToWater:Cooling");
+      return getAutosizedValue("Design Size Rated Air Volume Flow Rate in Cooling Mode", "m3/s");
     }
 
     boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedWaterFlowRateinCoolingMode() const {
-      return getAutosizedValue("Design Size Load Side Volume Flow Rate", "m3/s", "HeatPump:AirToWater:Cooling");
+      return getAutosizedValue("Design Size Rated Water Volume Flow Rate in Cooling Mode", "m3/s");
+    }
+
+    boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedHeatingCapacity() const {
+      return getAutosizedValue("Design Size Rated Heating Capacity", "W");
+    }
+
+    boost::optional<double> HeatPumpAirToWater_Impl::autosizedRatedCoolingCapacity() const {
+      return getAutosizedValue("Design Size Rated Cooling Capacity", "W");
     }
 
     void HeatPumpAirToWater_Impl::autosize() {}
@@ -760,6 +768,14 @@ namespace model {
     return getImpl<detail::HeatPumpAirToWater_Impl>()->autosizedRatedWaterFlowRateinHeatingMode();
   }
 
+  boost::optional<double> HeatPumpAirToWater::autosizedRatedHeatingCapacity() const {
+    return getImpl<detail::HeatPumpAirToWater_Impl>()->autosizedRatedHeatingCapacity();
+  }
+
+  boost::optional<double> HeatPumpAirToWater::autosizedRatedCoolingCapacity() const {
+    return getImpl<detail::HeatPumpAirToWater_Impl>()->autosizedRatedCoolingCapacity();
+  }
+
   /// @cond
   HeatPumpAirToWater::HeatPumpAirToWater(std::shared_ptr<detail::HeatPumpAirToWater_Impl> impl) : StraightComponent(std::move(impl)) {}
   /// @endcond

src/model/HeatPumpAirToWater.hpp

@@ -161,6 +161,8 @@ namespace model {
     boost::optional<double> autosizedRatedWaterFlowRateinHeatingMode() const;
     boost::optional<double> autosizedRatedAirFlowRateinCoolingMode() const;
     boost::optional<double> autosizedRatedWaterFlowRateinCoolingMode() const;
+    boost::optional<double> autosizedRatedHeatingCapacity() const;
+    boost::optional<double> autosizedRatedCoolingCapacity() const;
 
     //@}
    protected:

src/model/HeatPumpAirToWaterCooling.cpp

@@ -348,9 +348,21 @@ namespace model {
       return result;
     }
 
+    boost::optional<double> HeatPumpAirToWaterCooling_Impl::autosizedRatedCoolingCapacity() const {
+      boost::optional<double> result;
+      if (auto awhp_ = heatPumpAirToWater()) {
+        result = awhp_->autosizedRatedCoolingCapacity();
+      }
+      return result;
+    }
+
     void HeatPumpAirToWaterCooling_Impl::autosize() {
       autosizeRatedAirFlowRate();
       autosizeRatedWaterFlowRate();
+      auto speeds = this->speeds();
+      if (!speeds.empty()) {
+        speeds.back().autosize();  // Only need/can autosize the last (highest) speed
+      }
     }
 
     void HeatPumpAirToWaterCooling_Impl::applySizingValues() {
@@ -361,6 +373,13 @@ namespace model {
       if (boost::optional<double> val_ = autosizedRatedWaterFlowRate()) {
         setRatedWaterFlowRate(*val_);
       }
+
+      if (boost::optional<double> val_ = autosizedRatedCoolingCapacity()) {
+        auto speeds = this->speeds();
+        if (!speeds.empty()) {
+          speeds.back().setRatedCoolingCapacity(*val_);  // Only need/can autosize the last (highest) speed
+        }
+      }
     }
 
     ComponentType HeatPumpAirToWaterCooling_Impl::componentType() const {
@@ -714,6 +733,10 @@ namespace model {
     return getImpl<detail::HeatPumpAirToWaterCooling_Impl>()->heatPumpAirToWater();
   }
 
+  boost::optional<double> HeatPumpAirToWaterCooling::autosizedRatedCoolingCapacity() const {
+    return getImpl<detail::HeatPumpAirToWaterCooling_Impl>()->autosizedRatedCoolingCapacity();
+  }
+
   /// @cond
   HeatPumpAirToWaterCooling::HeatPumpAirToWaterCooling(std::shared_ptr<detail::HeatPumpAirToWaterCooling_Impl> impl)
     : StraightComponent(std::move(impl)) {}

src/model/HeatPumpAirToWaterCooling.hpp

@@ -172,6 +172,7 @@ namespace model {
     // Autosize methods
     boost::optional<double> autosizedRatedAirFlowRate() const;
     boost::optional<double> autosizedRatedWaterFlowRate() const;
+    boost::optional<double> autosizedRatedCoolingCapacity() const;  // Convenience method
 
     //@}
    protected:

src/model/HeatPumpAirToWaterCoolingSpeedData.cpp

@@ -88,7 +88,33 @@ namespace model {
     }
 
     boost::optional<double> HeatPumpAirToWaterCoolingSpeedData_Impl::autosizedRatedCoolingCapacity() {
-      return getAutosizedValue("TODO_CHECK_SQL Rated Cooling Capacity", "W");
+      boost::optional<double> result;
+      auto awhp_ccs = heatPumpAirToWaterCoolings();
+      if (awhp_ccs.empty()) {
+        return result;
+      }
+      size_t n_found = 0;
+      for (const auto& awhp_cc : awhp_ccs) {
+        // Check needed because could be the booster speed
+        if (awhp_cc.speeds().empty()) {
+          continue;
+        }
+        // It has to be the last speed
+        if (awhp_cc.speeds().back().handle() != this->handle()) {
+          continue;
+        }
+        if (n_found == 0) {
+          // Setting the first one only
+          result = awhp_cc.autosizedRatedCoolingCapacity();
+        }
+        ++n_found;
+      }
+      if (n_found > 1) {
+        LOG(Warn, briefDescription() << " is used as the highest speed in multiple HeatPumpAirToWaterCooling objects, "
+                                        "returning the autosized value from the first one only.");
+      }
+
+      return result;
     }
 
     double HeatPumpAirToWaterCoolingSpeedData_Impl::ratedCOPforCooling() const {

src/model/HeatPumpAirToWaterCooling_Impl.hpp

@@ -165,6 +165,8 @@ namespace model {
 
       boost::optional<double> autosizedRatedAirFlowRate() const;
       boost::optional<double> autosizedRatedWaterFlowRate() const;
+      boost::optional<double> autosizedRatedCoolingCapacity() const;  // Convenience method
+
       //@}
      protected:
      private:

src/model/HeatPumpAirToWaterHeating.cpp

@@ -348,9 +348,21 @@ namespace model {
       return result;
     }
 
+    boost::optional<double> HeatPumpAirToWaterHeating_Impl::autosizedRatedHeatingCapacity() const {
+      boost::optional<double> result;
+      if (auto awhp_ = heatPumpAirToWater()) {
+        result = awhp_->autosizedRatedHeatingCapacity();
+      }
+      return result;
+    }
+
     void HeatPumpAirToWaterHeating_Impl::autosize() {
       autosizeRatedAirFlowRate();
       autosizeRatedWaterFlowRate();
+      auto speeds = this->speeds();
+      if (!speeds.empty()) {
+        speeds.back().autosize();  // Only need/can autosize the last (highest) speed
+      }
     }
 
     void HeatPumpAirToWaterHeating_Impl::applySizingValues() {
@@ -361,6 +373,13 @@ namespace model {
       if (boost::optional<double> val_ = autosizedRatedWaterFlowRate()) {
         setRatedWaterFlowRate(*val_);
       }
+
+      if (boost::optional<double> val_ = autosizedRatedHeatingCapacity()) {
+        auto speeds = this->speeds();
+        if (!speeds.empty()) {
+          speeds.back().setRatedHeatingCapacity(*val_);  // Only need/can autosize the last (highest) speed
+        }
+      }
     }
 
     ComponentType HeatPumpAirToWaterHeating_Impl::componentType() const {
@@ -715,6 +734,10 @@ namespace model {
     return getImpl<detail::HeatPumpAirToWaterHeating_Impl>()->heatPumpAirToWater();
   }
 
+  boost::optional<double> HeatPumpAirToWaterHeating::autosizedRatedHeatingCapacity() const {
+    return getImpl<detail::HeatPumpAirToWaterHeating_Impl>()->autosizedRatedHeatingCapacity();
+  }
+
   /// @cond
   HeatPumpAirToWaterHeating::HeatPumpAirToWaterHeating(std::shared_ptr<detail::HeatPumpAirToWaterHeating_Impl> impl)
     : StraightComponent(std::move(impl)) {}

src/model/HeatPumpAirToWaterHeating.hpp

@@ -172,6 +172,7 @@ namespace model {
     // Autosize methods
     boost::optional<double> autosizedRatedAirFlowRate() const;
     boost::optional<double> autosizedRatedWaterFlowRate() const;
+    boost::optional<double> autosizedRatedHeatingCapacity() const;  // Convenience method
 
     //@}
    protected:

src/model/HeatPumpAirToWaterHeatingSpeedData.cpp

@@ -88,7 +88,33 @@ namespace model {
     }
 
     boost::optional<double> HeatPumpAirToWaterHeatingSpeedData_Impl::autosizedRatedHeatingCapacity() {
-      return getAutosizedValue("TODO_CHECK_SQL Rated Heating Capacity", "W");
+      boost::optional<double> result;
+      auto awhp_hcs = heatPumpAirToWaterHeatings();
+      if (awhp_hcs.empty()) {
+        return result;
+      }
+      size_t n_found = 0;
+      for (const auto& awhp_hc : awhp_hcs) {
+        // Check needed because could be the booster speed
+        if (awhp_hc.speeds().empty()) {
+          continue;
+        }
+        // It has to be the last speed
+        if (awhp_hc.speeds().back().handle() != this->handle()) {
+          continue;
+        }
+        if (n_found == 0) {
+          // Setting the first one only
+          result = awhp_hc.autosizedRatedHeatingCapacity();
+        }
+        ++n_found;
+      }
+      if (n_found > 1) {
+        LOG(Warn, briefDescription() << " is used as the highest speed in multiple HeatPumpAirToWaterHeating objects, "
+                                        "returning the autosized value from the first one only.");
+      }
+
+      return result;
     }
 
     double HeatPumpAirToWaterHeatingSpeedData_Impl::ratedCOPforHeating() const {

src/model/HeatPumpAirToWaterHeating_Impl.hpp

@@ -165,6 +165,8 @@ namespace model {
 
       boost::optional<double> autosizedRatedAirFlowRate() const;
       boost::optional<double> autosizedRatedWaterFlowRate() const;
+      boost::optional<double> autosizedRatedHeatingCapacity() const;  // Convenience method
+
       //@}
      protected:
      private:

src/model/HeatPumpAirToWater_Impl.hpp

@@ -177,6 +177,8 @@ namespace model {
       boost::optional<double> autosizedRatedWaterFlowRateinHeatingMode() const;
       boost::optional<double> autosizedRatedAirFlowRateinCoolingMode() const;
       boost::optional<double> autosizedRatedWaterFlowRateinCoolingMode() const;
+      boost::optional<double> autosizedRatedHeatingCapacity() const;
+      boost::optional<double> autosizedRatedCoolingCapacity() const;
 
       //@}
      protected: