-
Notifications
You must be signed in to change notification settings - Fork 233
Fix C# bindings - unbreak the build and add missing partial classes #5377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
180df4e
Hotfix C# bindings for #5365
jmarrec f50acda
Fix C# bindings for #5312
jmarrec f3e5d52
Add missing Partial Classes for EMSActuator
jmarrec 94cebdc
Add missing partial classes for AirCondVRF to add/remove/list terminals
jmarrec 84038b4
Add missing partial classes for ExternalFile::chillerElectricASHRAE205s
jmarrec b8f1feb
Add missing template for OptionalEpwGroundTemperatureDepth
jmarrec 6c1d417
C# bindings for WorkflowJSON::getMeasureStepsWithIndex
jmarrec 79e8d64
XmlValidator: import LocalBCL for BCLXMLType is swigged properly
jmarrec 3d1f3fd
Partial classes for Space related to ZoneMixing getters
jmarrec 789d107
Ignore protected Impl ctors from swig type things
jmarrec 1c2ab98
last missing swig type I can fix: AlfalfaComponentBase
jmarrec 92336a6
Try fixing the C# test step by allowing NET7, NET8, NET9 and NET10 (G…
jmarrec ecc90ca
Whatever - set the C# test project to use NET8 and be done with it [s…
jmarrec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my attempt at fixing the C# test step, just allow whatever is on the GHA runner.
Launch a run at https://github.com/NREL/OpenStudio/actions/runs/14217768843
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this would allow testing with ANY version installed in that list, but it seems that it tries to do ALL of them so the workflow is probably going to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MEH, just going to use NET8 and keep move on for now.
Launched at https://github.com/NREL/OpenStudio/actions/runs/14218506478
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that run worked, including testing.