feat(cli): add structured exit codes for improper termination - #2137
Closed
rwinkelman wants to merge 3 commits into
Closed
feat(cli): add structured exit codes for improper termination#2137rwinkelman wants to merge 3 commits into
rwinkelman wants to merge 3 commits into
Conversation
Introduces positive ExitCode values (issue NVIDIA#1221) and exits with INTERRUPTED on KeyboardInterrupt and UNSPECIFIED for GarakException. Signed-off-by: Ray Winkelman <rwinkelman@users.noreply.github.com>
rwinkelman
force-pushed
the
fix/cli-exit-codes-1221
branch
from
September 1, 2026 07:44
e78d029 to
faf9c33
Compare
Author
|
Follow-up: harness now wraps probe/detector/evaluator failures; generator load, langservice, buff load, and report digest failures propagate component-specific exit codes. |
rwinkelman
force-pushed
the
fix/cli-exit-codes-1221
branch
from
September 1, 2026 08:02
f6d5181 to
bd0de61
Compare
Signed-off-by: Ray Winkelman <rwinkelman@users.noreply.github.com>
Collaborator
|
Closing in favor of #1790 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
garak.exit_codes.ExitCodewith positive status codes per arch: give exit codes on improper exit #1221 (shells truncate negatives).INTERRUPTED(1) onKeyboardInterruptandUNSPECIFIED(127) onGarakException/ValueError.GarakException.exit_codefor finer-grained mapping in follow-ups.Fixes #1221 (initial wiring; component-specific codes can land incrementally).
Test plan
pytest tests/test_exit_codes.py