Skip to content

Deselect the upstream Delta deletion vector test that reads Polars' log - #25065

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:deselect-delta-dv-single-test
Nov 4, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:deselect-delta-dv-single-test

Conversation

@Matt711

@Matt711 Matt711 commented Nov 4, 2026

Copy link
Copy Markdown
Member

Description

test_scan_delta_dv_single asserts on the verbose log Polars writes while it reads a Delta table. cudf-polars reads the table since #24345, so the log is never written and the nightly job fails. Deselect it with the reason.

closes #25063

Verification

Check Result
run_cudf_polars_polars_tests.sh --run-slow --engine in-memory -k test_delta_deletion_vector, before 6 failed (the CI assertion)
Same, after 42 passed, 5 skipped, 1 xfailed
Same with --engine spmd, after 42 passed, 5 skipped, 1 xfailed

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Tools: Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Nov 4, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@Matt711
Matt711 marked this pull request as ready for review November 4, 2026 14:13
@Matt711
Matt711 requested a review from a team as a code owner November 4, 2026 14:13
@Matt711
Matt711 requested a review from wence- November 4, 2026 14:13
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Tests
    • Updated automated test selection for a Delta-table logging check. The check is now excluded from the selected test runs.

The Polars test deselection list now skips test_scan_delta_dv_single. A comment explains that the test checks verbose logging from Polars, while cudf-polars reads the Delta table.

Changes: Delta test deselection

Layer / File(s) Summary
Document and skip the test
ci/cudf_polars/polars_test_deselections.txt
Adds a comment about the Polars-specific verbose-log assertion and skips test_scan_delta_dv_single.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Possibly related issues

Possibly related PRs

  • NVIDIA/cudf#24345 — Adds Delta scan support in cudf-polars, which reads the table instead of Polars.
Merge Risk: Minimal · up to 69de7

The focused test deselection aligns with the stated cudf-polars behavior and is mergeable.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title names the main change: deselecting the upstream Delta deletion vector test that asserts on Polars' verbose log. The raw summary confirms a skip-list entry for test_scan_delta_dv_single with …
Description check Passed The description states the problem: test_scan_delta_dv_single asserts on Polars' verbose log, which cudf-polars no longer writes since #24345, so the nightly job fails. It explains the fix (deselectin…
Linked Issues check Passed Issue #25063 requires the nightly job to stop failing on tests/unit/io/test_delta_deletion_vector.py::test_scan_delta_dv_single, which asserts on Polars verbose output that cudf-polars does not prod…
Out of Scope Changes check Passed The whole-PR diff contains only one deselection entry and two comments that explain its connection to issue #25063. No unrelated changes are present.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check

Explanation

The title names the main change: deselecting the upstream Delta deletion vector test that asserts on Polars' verbose log. The raw summary confirms a skip-list entry for test_scan_delta_dv_single with a documented reason, and the objectives describe the same change. The title is specific and matches the changeset, so it passes.

Full details: Description check

Explanation

The description states the problem: test_scan_delta_dv_single asserts on Polars' verbose log, which cudf-polars no longer writes since #24345, so the nightly job fails. It explains the fix (deselecting the test with a reason), links issue #25063, and gives verification results. It is directly related to the changeset, so it passes.

Full details: Linked Issues check

Explanation

Issue #25063 requires the nightly job to stop failing on tests/unit/io/test_delta_deletion_vector.py::test_scan_delta_dv_single, which asserts on Polars verbose output that cudf-polars does not produce. The PR adds that exact test to ci/cudf_polars/polars_test_deselections.txt and records the reason. This implements the requested coding change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: NVIDIA/cudf
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 0765b8f
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: a7a30ad4-3e74-4ce0-a1ba-af9b24ff8e02
Commits

Reviewing files that changed from the base of the PR and between 0765b8f and 69de7ba.

Files selected for processing: 1
  • ci/cudf_polars/polars_test_deselections.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@TomAugspurger TomAugspurger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in #25024 I guess.

@Matt711

Matt711 commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit f12ee2d into NVIDIA:main Nov 4, 2026
76 checks passed
@Matt711
Matt711 deleted the deselect-delta-dv-single-test branch November 4, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Nightly cudf-polars-polars-tests: test_scan_delta_dv_single fails because cudf-polars now reads Delta tables

2 participants