Repository navigation
Convert IO tests' scratch rmm::device_uvector<T> to cuda::device_buffer<T> - #24963
Conversation
…uffer<T>` Use CCCL buffers instead of RMM vectors in IO tests. Issue: rapidsai/build-planning#321
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Compression and logical-stack test buffers cpp/tests/io/comp/comp_test.cpp, cpp/tests/io/fst/logical_stack_test.cu |
Compression tests use CUDA device buffers and limit the compressed input span to bytes_written. The logical-stack test creates buffers from host vectors and passes the index buffer directly. |
JSON test buffers cpp/tests/io/json/json_tree_csr.cu, cpp/tests/io/json/nested_json_test.cpp |
JSON tests use CUDA device buffers or buffer factories for column IDs, node IDs, parser inputs, offsets, tokens, and token indexes. |
Parquet buffer source cpp/tests/io/parquet_writer_test.cpp |
The Parquet writer test creates its device-side input with make_device_buffer. The device span and read operation remain in place. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Refactor
Possibly related issues
- NVIDIA/cudf issue 24431: The issue tracks the transition from RMM buffers to
cuda::device_buffer. This PR applies the same migration to allocations in IO tests.
Suggested reviewers: vyasr, bdice, davidwendt
Merge Risk: 
Minimal · up to e3ef0
-
No merge-blocking defect is established for this test-only buffer migration.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 5 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
/merge |
Description
Use CCCL buffers instead of RMM vectors in IO tests.
Issue: rapidsai/build-planning#321
Checklist