Skip to content
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1bd2d66
Enable _reset to update quent_context; fast quent integration tests
TomAugspurger Oct 16, 2026
a8d2dd4
Deduplicate quent open/close across engine _reset methods
TomAugspurger Oct 16, 2026
33820dd
Use fallback_mode=silent in quent integration tests
TomAugspurger Oct 16, 2026
6f302e2
Clarify why engine_with_quent_context uses _unconfigured_engine directly
TomAugspurger Oct 16, 2026
4a3de24
Preserve allow_gpu_sharing across _reset calls
TomAugspurger Oct 16, 2026
c5a5234
Fix Ray quent test: pass full engine_options in the in-test _reset
TomAugspurger Oct 16, 2026
9da5f3f
Fix stale Quent closure capture in Ray/Dask shutdown callbacks
TomAugspurger Oct 16, 2026
6243197
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger Oct 19, 2026
ec21c4c
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger Oct 19, 2026
625885f
Ensure shutdown in dask/ray engine
TomAugspurger Oct 19, 2026
257cd05
bigger refactor
TomAugspurger Oct 19, 2026
154e2bd
coverage
TomAugspurger Oct 19, 2026
557bbd6
Move the test
TomAugspurger Oct 19, 2026
436e0fa
sync quent context
TomAugspurger Oct 20, 2026
b2b0a4f
set_quent
TomAugspurger Oct 20, 2026
e2599f8
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger Oct 20, 2026
9dab31b
ensure closed
TomAugspurger Oct 20, 2026
06b884d
wip
TomAugspurger Oct 20, 2026
ddfd1d4
wip
TomAugspurger Oct 20, 2026
3d623f5
fixup
TomAugspurger Oct 20, 2026
019c4a2
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger Oct 20, 2026
ce04869
Merge branch 'main' into tom/fast-quent-tests
TomAugspurger Oct 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions python/cudf_polars/cudf_polars/engine/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -539,12 +539,6 @@ def _reset(
existing_executor_options = self.config.get("executor_options", {})
if not isinstance(existing_executor_options, dict):
existing_executor_options = {}
existing_quent_context = existing_executor_options.get("quent_context")
if (
"quent_context" in executor_options
and executor_options["quent_context"] != existing_quent_context
):
raise ValueError("quent_context cannot be changed during reset")

_disallowed_exec = {"num_py_executors"} & executor_options.keys()
if _disallowed_exec:
Expand Down Expand Up @@ -589,6 +583,12 @@ def __exit__(self, *_: object) -> None:
"""Exit the context manager, calling :meth:`shutdown`."""
self.shutdown()

def _set_quent(self, quent_context: QuentConfig | None) -> QuentConfig | None:
"""Replace this engine's Quent runtimes and return the effective config."""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Replace this engine's Quent runtimes and return the effective config."""
"""
Replace this engine's Quent runtimes.
Closes any running Quent runtimes, then starts new ones for
``quent_context`` unless it is ``None``.
Parameters
----------
quent_context
Quent configuration to start, or ``None`` to only close.
Returns
-------
The effective Quent configuration, which may differ from
``quent_context``, or ``None`` if Quent is disabled.
"""

raise NotImplementedError( # pragma: no cover
f"{type(self).__name__} does not implement _set_quent"
)

def _run(self, func: Callable[..., T], *args: Any, **kwargs: Any) -> list[T]:
"""
Execute a function on all ranks.
Expand Down
Loading
Loading