Repository navigation
Allow for reseting the Quent context in StreamingEngine._reset
#24649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomAugspurger
wants to merge
22
commits into
NVIDIA:main
Choose a base branch
from
TomAugspurger:tom/fast-quent-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+575
−385
Open
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1bd2d66
Enable _reset to update quent_context; fast quent integration tests
TomAugspurger a8d2dd4
Deduplicate quent open/close across engine _reset methods
TomAugspurger 33820dd
Use fallback_mode=silent in quent integration tests
TomAugspurger 6f302e2
Clarify why engine_with_quent_context uses _unconfigured_engine directly
TomAugspurger 4a3de24
Preserve allow_gpu_sharing across _reset calls
TomAugspurger c5a5234
Fix Ray quent test: pass full engine_options in the in-test _reset
TomAugspurger 9da5f3f
Fix stale Quent closure capture in Ray/Dask shutdown callbacks
TomAugspurger 6243197
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger ec21c4c
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger 625885f
Ensure shutdown in dask/ray engine
TomAugspurger 257cd05
bigger refactor
TomAugspurger 154e2bd
coverage
TomAugspurger 557bbd6
Move the test
TomAugspurger 436e0fa
sync quent context
TomAugspurger b2b0a4f
set_quent
TomAugspurger e2599f8
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger 9dab31b
ensure closed
TomAugspurger 06b884d
wip
TomAugspurger ddfd1d4
wip
TomAugspurger 3d623f5
fixup
TomAugspurger 019c4a2
Merge remote-tracking branch 'upstream/main' into tom/fast-quent-tests
TomAugspurger ce04869
Merge branch 'main' into tom/fast-quent-tests
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.