Skip to content

Resolve Node runtime deprecations in YARN checks - #273

Merged
pxLi merged 1 commit into
NVIDIA:devfrom
pxLi:fix-actions-deprecations
Sep 22, 2026
Merged

pxLi merged 1 commit into
NVIDIA:devfrom
pxLi:fix-actions-deprecations

Conversation

@pxLi

@pxLi pxLi commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

Description

Resolve the Node runtime deprecation warnings in the YARN resource cost checks by using NVIDIA/spark-rapids-common/checkout@main and actions/setup-python@v7. Keep the Python 3.10/3.11/3.12 matrix, triggers, and test commands unchanged.

Validation

  • All 60 YARN resource cost unit tests passed in an isolated environment with the declared zstandard dependency installed.
  • YAML parsing and structural comparison passed: only the action references change.
  • git diff --check passed.
  • The complete hosted Python-version matrix remains to be validated in CI.

Deprecation References

Signed-off-by: Peixin Li <pxLi@nyu.edu>
@greptile-apps

greptile-apps Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking recommendation to pin the shared checkout action to an immutable commit.

Findings

  1. P2 Security Mutable checkout reference ▶

Summary

This PR updates the YARN resource-cost workflow's checkout and Python setup actions while retaining its triggers, Python matrix, and test commands.

  • Replaces actions/checkout@v4 with the shared NVIDIA checkout action.
  • Upgrades actions/setup-python from v5 to v7.
  • Leaves one non-blocking supply-chain hardening concern because the checkout action follows a mutable branch.

Reviews (1) · Last reviewed commit: "Resolve GitHub Actions deprecation warni..."

@pxLi pxLi self-assigned this Sep 22, 2026
@pxLi pxLi added the build label Sep 22, 2026
@pxLi
pxLi requested review from YanxuanLiu and yinqingh September 22, 2026 04:28
@pxLi
pxLi merged commit efcfa3f into NVIDIA:dev Sep 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants