ci: avoid anonymous Hermes source fetches - #264
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (18)
🧰 Additional context used📓 Path-based instructions (13)Put `permissions:` on each job that needs token access.📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md) Files:
Every external action is pinned to a full SHA📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md) Files:
- Blind repository-wide replacement of version-like strings.📄 CodeRabbit inference engine (.agents/skills/update-project-version/SKILL.md) Files:
- Format changed files with the language-native formatter before the final📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md) Files:
Draft release notes only from verified repository evidence; verify each candidate claim against changed public documentation, API types, command help, or source before publication.📄 CodeRabbit inference engine (.agents/skills/draft-release-notes/SKILL.md) Files:
Keep pull request branch scope coherent and reviewable.📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md) Files:
Package names, import paths, and module names are internally consistent📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md) Files:
Add the package to the root adapter-test dependency group,📄 CodeRabbit inference engine (.agents/skills/contribute-adapter/SKILL.md) Files:
just --fmt --check📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md) Files:
Always spell `NVIDIA` in all caps; do not use `Nvidia`, `nvidia`, `nVidia`, `nVIDIA`, or `NV`.📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md) Files:
Before implementing, explicitly state assumptions, surface ambiguity and tradeoffs, present multiple interpretations when relevant, and ask for clarification rather than silently deciding or proceeding when requirements are unclear.📄 CodeRabbit inference engine (.agents/skills/karpathy-guidelines/SKILL.md) Files:
Keep the tiers separate: do not add external integration guidance to the📄 CodeRabbit inference engine (AGENTS.md) Files:
Reproduce or identify the failing behavior before making a small NeMo Fabric bug fix.📄 CodeRabbit inference engine (.agents/skills/small-fix/SKILL.md) Files:
🪛 zizmor (1.29.0).github/workflows/ci_check.yml[warning] 4-81: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block (excessive-permissions) .github/workflows/fern-docs.yml[warning] 4-439: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block (excessive-permissions) .github/workflows/ci_python.yml[warning] 4-203: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block (excessive-permissions) 🔇 Additional comments (5)
WalkthroughThe workflows now check out a pinned Hermes Agent repository for CI, wheel builds, and documentation. The installation command checks the current commit and updates the checkout only when required. ChangesHermes Agent checkout
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change replaces anonymous Hermes source fetches in CI with pinned checkouts and preserves the local fallback behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Fern docs preview: https://nvidia-preview-pull-request-264.docs.buildwithfern.com/nemo/fabric |
|
/merge |
Overview
Replace anonymous Hermes Agent fetches in GitHub Actions with authenticated, commit-pinned secondary checkouts. This prevents the Python, wheel, pre-commit, and Fern preview jobs from independently hitting GitHub's anonymous Git rate limit while preserving the existing local installation workflow.
Details
NousResearch/hermes-agentat the Fabric-pinned commit with the existing full-SHA-pinnedactions/checkoutaction.external/hermes-agent.just install-hermes-agentto validate the currentHEADand skipgit fetchwhen CI has already supplied the exact pinned commit.uv syncand its existing lockfile-backed cache for installation.Validation
just --fmt --checkgit diff --checkpre-commit run copyright-header --files .github/workflows/ci_check.yml .github/workflows/ci_python.yml .github/workflows/fern-docs.yml justfilepre-commit run actionlint --all-filesgit fetchand a mismatched checkout retains the fetch-and-checkout fallbackThe full Python matrix was not run locally because no Python or product behavior changed; the pull request's ordinary GitHub Actions jobs provide the end-to-end checkout and installation validation. NVSkills was not invoked.
Where should the reviewer start?
Start with
justfileand then compare the secondary checkout in.github/workflows/ci_python.ymlwith the existing Hermes installation step.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Relates to: none
I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.
Summary by CodeRabbit