fix(langchain): support Windows graph paths - #2192
Conversation
Signed-off-by: mikemikimike <13286568797@163.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe graph reference parser now splits at the final colon, supports Windows drive-letter paths, rejects missing components, and is covered by focused parameterized tests. ChangesGraph path parsing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change adds support for Windows graph paths while preserving rejection of invalid references; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes satisfy issue [ ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test 423397b |
|
@mikemikimike pre-commit is failing |
Signed-off-by: mikemikimike <13286568797@163.com>
|
/ok to test dc6c806 |
|
Fixed the pre-commit failure by applying the yapf-required formatting to the ValueError in |
Summary
langgraph_wrappergraph referencesValidation
python -m pytest packages/nvidia_nat_langchain/tests/test_langgraph_workflow.py -q(26 passed)ruff check packages/nvidia_nat_langchain/src/nat/plugins/langchain/langgraph_workflow.py packages/nvidia_nat_langchain/tests/test_langgraph_workflow.pypython -m compileall -q packages/nvidia_nat_langchain/src/nat/plugins/langchain/langgraph_workflow.py packages/nvidia_nat_langchain/tests/test_langgraph_workflow.pygit diff --checkCloses #2185
Summary by CodeRabbit
Bug Fixes
Tests