fix(server)!: remove inline config from /v1/checks endpoint - #2228
Merged
Conversation
Pouyanpi
approved these changes
Jul 28, 2026
Pouyanpi
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @m-misiura for fixing this 👍🏻
m-misiura
added a commit
to m-misiura/NeMo-Guardrails
that referenced
this pull request
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The inline config specification should be dropped from
v1/checksendpoint as it mixes control and data planes. This impacts PR#2205, so it's probably prudent to review this first and then I will subsequently revise the aforementioned PRRelated Issue(s)
No issue was filed, but this was discussed previously
Verification
Revised tests pass:
uv run --locked pytest tests/server/test_guardrail_checks.py -v tests/server/test_guardrail_checks.py::test_status_mapping[passed-passed] PASSED [ 6%] tests/server/test_guardrail_checks.py::test_status_mapping[modified-modified] PASSED [ 13%] tests/server/test_guardrail_checks.py::test_status_mapping[blocked-blocked] PASSED [ 20%] tests/server/test_guardrail_checks.py::test_content_returned_on_passed PASSED [ 26%] tests/server/test_guardrail_checks.py::test_content_returned_on_modified PASSED [ 33%] tests/server/test_guardrail_checks.py::test_content_returned_on_blocked PASSED [ 40%] tests/server/test_guardrail_checks.py::test_rail_null_on_passed PASSED [ 46%] tests/server/test_guardrail_checks.py::test_config_id_resolves PASSED [ 53%] tests/server/test_guardrail_checks.py::test_default_config_used_when_none_specified PASSED [ 60%] tests/server/test_guardrail_checks.py::test_empty_messages_returns_422 PASSED [ 66%] tests/server/test_guardrail_checks.py::test_no_config_no_default_returns_422 PASSED [ 73%] tests/server/test_guardrail_checks.py::test_colang_v2_returns_422 PASSED [ 80%] tests/server/test_guardrail_checks.py::test_get_rails_failure_returns_422 PASSED [ 86%] tests/server/test_guardrail_checks.py::test_check_async_failure_returns_500 PASSED [ 93%] tests/server/test_guardrail_checks.py::test_context_prepended_to_messages PASSED [100%] ============================== 15 passed in 2.12s ==============================AI Assistance
Checklist