feat(engine): add Datum-based forward, backward, and optimizer APIs - #3614
Draft
HuiyingLi wants to merge 22 commits into
Draft
feat(engine): add Datum-based forward, backward, and optimizer APIs#3614HuiyingLi wants to merge 22 commits into
HuiyingLi wants to merge 22 commits into
Conversation
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
…orward-backward # Conflicts: # nemo_automodel/recipes/llm/train_ft.py # nemo_automodel/recipes/vlm/finetune.py # tests/unit_tests/recipes/test_finetune_vlm_helpers.py # tests/unit_tests/recipes/test_train_ft.py Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
…orward-backward Signed-off-by: HuiyingLi <willwin.lee@gmail.com> # Conflicts: # nemo_automodel/components/distributed/pipelining/autopipeline.py # nemo_automodel/recipes/llm/train_ft.py # nemo_automodel/recipes/vlm/finetune.py
HuiyingLi
force-pushed
the
huiyingl/feat/datum-forward-backward
branch
from
August 21, 2026 18:54
a238fa5 to
645e5ae
Compare
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Introduce a Datum-first Engine boundary for forward, forward-backward, distributed batch routing, and optimizer updates so LLM/VLM recipes no longer own PP/CP/FSDP execution details.
Changelog
Engine.forwardandEngine.forward_backwardresults, including exact loss numerator and denominator statistics.Engine.optim_step.Validation
328 passed, 12 skippedacross Engine, FP8, LLM recipe, and VLM recipe unit suites.git diff --checkpass.Before your PR is "Ready for review"
Pre checks:
This is intentionally opened as a Draft while full CI and final reviewer feedback are pending.
Additional Information