Skip to content

build: pySHiELD has no py-3.13 support due to pyrte-rrtmgp - #111

Merged
fmalatino merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/no-py-3.13-support
Sep 4, 2026
Merged

fmalatino merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/no-py-3.13-support

Conversation

@romanc

@romanc romanc commented Aug 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

pySHiELD has a hard dependency on pyrte-rrtmgp. That "NOAA-version" of this library only supports python versions 3.11 and 3.12. Any attempt to install pySHiELD with python 3.13 will thus result in an error stating that pyrte-rrtmgp can't be installed.

This issue will transitively affect pace since pySHiELD is a dependency of pace, see NOAA-GFDL/pace#208.

Note: the "upstream" version of pyrte-rrtmgp has support for python 3.13 and 3.14. Once someone pulls the upstream changes down into the "NOAA version", we can re-enable more versions of python.

How Has This Been Tested?

Tried a local install of pySHiELD with python 3.14 in the context of NOAA-GFDL/NDSL#554.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A
  • Targeted model, if this change was triggered by a model need/shortcoming: N/A

pySHiELD has a hard dependency on pyrte-rrtmgp. That "NOAA-version" of
this library only supports python versions 3.11 and 3.12. Any attempt to
install pySHiELD with python 3.13 will thus result in an error stating
that `pyrte-rrtmgp`  can't be installed.

This issue will transitatively affect `pace` (since pySHiELD is a
dependency of `pace`).

Note: the "upstream" version of `pyrte-rrtmgp` has support for python
3.13 and 3.14. Once someone pulls the upstream changes down into the
"NOAA version", we can re-enable more versions of python.
@romanc
romanc requested review from fmalatino and oelbert August 28, 2026 06:09

@fmalatino fmalatino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

@romanc

romanc commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

Do you still want to merge this PR then? Like, will it be fast for you to update pyrte-rrtmgp and then this PR is not needed? Or should we merge this PR in between?

@fmalatino

Copy link
Copy Markdown
Contributor

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

Do you still want to merge this PR then? Like, will it be fast for you to update pyrte-rrtmgp and then this PR is not needed? Or should we merge this PR in between?

Lets merge this one and then when pyrte-rrtmgp is ready we can amend so as to not hold things up.

@romanc

romanc commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

Do you still want to merge this PR then? Like, will it be fast for you to update pyrte-rrtmgp and then this PR is not needed? Or should we merge this PR in between?

Lets merge this one and then when pyrte-rrtmgp is ready we can amend so as to not hold things up.

Sounds good. I don't have merge rights in pySHiELD and pace, so you will have to press the buttons.

@fmalatino

Copy link
Copy Markdown
Contributor

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

Do you still want to merge this PR then? Like, will it be fast for you to update pyrte-rrtmgp and then this PR is not needed? Or should we merge this PR in between?

Lets merge this one and then when pyrte-rrtmgp is ready we can amend so as to not hold things up.

Sounds good. I don't have merge rights in pySHiELD and pace, so you will have to press the buttons.

I have opened up PR 6 in the NOAA pyrte-rrtmgp repository to enable environments with < Python 3.15

@romanc

romanc commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

I will pull in the "upstream" changes to the version we manage and reinstate the 3.13 support.

Do you still want to merge this PR then? Like, will it be fast for you to update pyrte-rrtmgp and then this PR is not needed? Or should we merge this PR in between?

Lets merge this one and then when pyrte-rrtmgp is ready we can amend so as to not hold things up.

Sounds good. I don't have merge rights in pySHiELD and pace, so you will have to press the buttons.

I have opened up PR 6 in the NOAA pyrte-rrtmgp repository to enable environments with < Python 3.15

Looks like NOAA-GFDL/pyRTE-RRTMGP#6 was not moving recently. Should we move with this PR and then undo it once NOAA-GFDL/pyRTE-RRTMGP#6 got merged?

@romanc

romanc commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

@fmalatino wdyt, should we merge here? I can't, you'd have to press the button ....

@fmalatino
fmalatino added this pull request to the merge queue Sep 4, 2026
Merged via the queue into NOAA-GFDL:develop with commit 7abb1b7 Sep 4, 2026
3 checks passed
@romanc
romanc deleted the romanc/no-py-3.13-support branch September 5, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants