Skip to content

refactor: avoid depreated stencils - #110

Merged
fmalatino merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/avoid-deprecated-stencils
Aug 25, 2026
Merged

refactor: avoid depreated stencils#110
fmalatino merged 1 commit into
NOAA-GFDL:developfrom
romanc:romanc/avoid-deprecated-stencils

Conversation

@romanc

@romanc romanc commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Follow from moving to NDSL 2026.08.00 in PR #109. This PR avoids importing deprecated stencils, which will allow us to clean up in the September release.

NOTE: pace tests will be okay, once pace is using NDSL 2026.08.00 (i.e. once NOAA-GFDL/pace#206 merges).

How Has This Been Tested?

All good as long as CI is still green.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included: N/A
  • Targeted model, if this change was triggered by a model need/shortcoming: N/A

@romanc
refactor: avoid depreated stencils
34bdd02 
Follow from moving to NDSL `2026.08.00` in PR NOAA-GFDL#109. This PR avoids
importing deprecated stencils, which will allow us to clean up in the
September release.
@romanc
romanc marked this pull request as ready for review August 24, 2026 12:41
@romanc
romanc requested a review from fmalatino August 24, 2026 12:41
@romanc

romanc commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

@twicki I can't add you as a reviewer ...

@fmalatino

fmalatino commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@twicki I can't add you as a reviewer ...

I just sent an invite for collaboration.

@romanc

romanc commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

@twicki I can't add you as a reviewer ...

I just sent an invite for collaboration.

Thanks, @fmalatino 🙏

twicki
twicki approved these changes Aug 25, 2026
View reviewed changes

@twicki twicki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up!

@fmalatino
fmalatino added this pull request to the merge queue Aug 25, 2026
Merged via the queue into NOAA-GFDL:develop with commit dc85a88 Aug 25, 2026
3 of 4 checks passed
@romanc
romanc deleted the romanc/avoid-deprecated-stencils branch August 25, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmalatino fmalatino fmalatino approved these changes
+1 more reviewer
@twicki twicki twicki approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romanc @fmalatino @twicki