Skip to content

Fix unpack_ocean_ice_boundary_calved_shelf_bergs #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hallberg-NOAA merged 2 commits into from
Mar 24, 2026
Merged

Fix unpack_ocean_ice_boundary_calved_shelf_bergs #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cb2816
Change fast ice to slow ice object when storing calving
NJSchlegel Nov 25, 2024
38b8d5b
Fix unpack_ocean_ice_boundary_calved_shelf_bergs
alex-huth Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions src/ice_model.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,15 +435,15 @@ subroutine unpack_ocean_ice_boundary_calved_shelf_bergs(Ice, OIB)

integer :: i, j, k, m, n, i2, j2, k2, isc, iec, jsc, jec, i_off, j_off

if (.not.associated(Ice%fCS)) call SIS_error(FATAL, &
"The pointer to Ice%fCS must be associated in unpack_ocean_ice_boundary_calved_shelf_bergs.")
if (.not.associated(Ice%fCS%FIA)) call SIS_error(FATAL, &
"The pointer to Ice%fCS%FIA must be associated in unpack_ocean_ice_boundary_calved_shelf_berg.")
if (.not.associated(Ice%fCS%G)) call SIS_error(FATAL, &
"The pointer to Ice%fCS%G must be associated in unpack_ocean_ice_boundary_calved_shelf_berg.")
if (.not.associated(Ice%sCS)) call SIS_error(FATAL, &
"The pointer to Ice%sCS must be associated in unpack_ocean_ice_boundary_calved_shelf_bergs.")
if (.not.associated(Ice%sCS%FIA)) call SIS_error(FATAL, &
"The pointer to Ice%sCS%FIA must be associated in unpack_ocean_ice_boundary_calved_shelf_berg.")
if (.not.associated(Ice%sCS%G)) call SIS_error(FATAL, &
"The pointer to Ice%sCS%G must be associated in unpack_ocean_ice_boundary_calved_shelf_berg.")

FIA => Ice%fCS%FIA ; G => Ice%fCS%G
US => Ice%fCS%US
FIA => Ice%sCS%FIA ; G => Ice%sCS%G
US => Ice%sCS%US

isc = G%isc ; iec = G%iec ; jsc = G%jsc ; jec = G%jec

Expand All @@ -453,15 +453,12 @@ subroutine unpack_ocean_ice_boundary_calved_shelf_bergs(Ice, OIB)
!$OMP private(i2,j2)
do j=jsc,jec ; do i=isc,iec ; if (G%mask2dT(i,j) > 0.0) then
i2 = i+i_off ; j2 = j+j_off
if (OIB%calving(i2,j2)>0.0) then
if (FIA%calving(i,j)>0.0) call SIS_error(FATAL,"Overlap in calving from snow discharge and ice shelf!")
FIA%calving(i,j) = US%kg_m2s_to_RZ_T*OIB%calving(i2,j2)
FIA%calving_hflx(i,j) = US%W_m2_to_QRZ_T*OIB%calving_hflx(i2,j2)
endif
FIA%calving(i,j) = FIA%calving(i,j) + US%kg_m2s_to_RZ_T*OIB%calving(i2,j2)
FIA%calving_hflx(i,j) = FIA%calving_hflx(i,j) + US%W_m2_to_QRZ_T*OIB%calving_hflx(i2,j2)
endif ; enddo ; enddo

if (Ice%fCS%debug) then
call FIA_chksum("End of unpack_ocean_ice_boundary_calved_shelf_berg", FIA, G, Ice%fCS%US)
if (Ice%sCS%debug) then
call FIA_chksum("End of unpack_ocean_ice_boundary_calved_shelf_berg", FIA, G, Ice%sCS%US)
endif

end subroutine unpack_ocean_ice_boundary_calved_shelf_bergs
Expand Down