Added bug flag for negative Kd with internal tides - #1175
Open
knlowman wants to merge 1 commit into
Open
Conversation
Hallberg-NOAA
added
Parameter change
Member
|
Thank you for tracking down and fixing this bug, @knlowman! This may be a case where the code is sufficiently new that we could fix this bug directly without having to introduce a bugfix runtime parameter. @raphaeldussin, would you support fixing this bug directly without retaining the ability to recreate it at runtime? Are you aware of any cases that have exercised this parameterization without explicitly setting a positive value of |
|
@knlowman @Hallberg-NOAA I'm fine with fixing the bug and removing the bug flag. The implementation looks correct so I'm happy either way, with or without the bug flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a bug flag (default = true/bug on) to fix the issue that occurs when Kd_max = -1 (the default when not specified). When Kd_max is negative and the internal tide ray tracing scheme is being used, the diapycnal diffusivity becomes -5 everywhere in the top and bottom interfaces and layers, and the internal tide contribution to diffusivity in the interior is essentially thrown out.