(*)Fix nonBousinesq handling of the case when sea level drops below the seafloor - #1161
Open
Hallberg-NOAA wants to merge 1 commit into
Open
(*)Fix nonBousinesq handling of the case when sea level drops below the seafloor#1161Hallberg-NOAA wants to merge 1 commit into
Hallberg-NOAA wants to merge 1 commit into
Conversation
Corrected the handling of sea surface heights dropping below the bathymetry in non-Boussinesq mode when INTEGRAL_BT_CONTINUITY is true. In non-Boussinesq mode, the eta variable in btstep() is the total depth of the water column, but the error handling in this case had been treating as though it were the sea surface height anomaly. As a result, there could be non-Boussinesq cases where the limiting was not being applied until eta is more than the depth of the ocean below the topography, but this could change drastically if the reference geopotential for the bathymetry (set via REFERENCE_HEIGHT) is non-zero. The revised code now sets the non-Boussinesq limit on eta to 0, as it should be. There is no bug-recovery flag in this case because this is an instance that corrects a situation that would have been failing previously with a fatal error. This commit also correct the descriptions in several places of the eta variable that is passed into btstep. All answers are bitwise identical in cases that were working previously.
Hallberg-NOAA
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the handling of sea surface heights dropping below the bathymetry in non-Boussinesq mode when
INTEGRAL_BT_CONTINUITYis true. In non-Boussinesq mode, theetavariable inbtstep()is the total depth of the water column, but the error handling in this case had been treating as though it were the sea surface height anomaly. As a result, there could be non-Boussinesq cases where the limiting was not being applied untiletais more than the depth of the ocean below the topography, but this could change drastically if the reference geopotential for the bathymetry (set viaREFERENCE_HEIGHT) is non-zero. The revised code now sets the non-Boussinesq limit onetato 0, as it should be. There is no bug-recovery flag in this case because this is an instance that corrects a situation that would have been failing previously with a fatal error.This commit also correct the descriptions in several places of the
etavariable that is passed intobtstep().All answers are bitwise identical in cases that were working previously.