-
Notifications
You must be signed in to change notification settings - Fork 70
Calve icebergs from ice-shelf flux #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-huth
wants to merge
16
commits into
NOAA-GFDL:main
Choose a base branch
from
alex-huth:iOM4_with_bergs_rebase
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3e80bbc
Calving of icebergs based on ice shelf flux through static ice front
alex-huth b8b8fd1
Merge remote-tracking branch 'GFDL/main' into iOM4_with_bergs_rebase
alex-huth 3707446
Merge remote-tracking branch 'GFDL/main' into iOM4_with_bergs_rebase
alex-huth 1a1fb22
make ice shelf calving parameters/routines public within full_coupler…
alex-huth 5181add
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 7b315cf
add missing fms_mpp_clock_begin for iceberg calving from ice shelves
alex-huth 49b5cbd
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 62c86b9
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 49dd08f
Merge remote-tracking branch 'GFDL/main' into iOM4_with_bergs_rebase
alex-huth 78f99ab
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 7c82e91
To reflect recent reorganization of coupler, moved calve_ice_shelf_be…
alex-huth afd4181
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth f7d4704
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 2c60aea
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 4e6be30
Merge branch 'main' into iOM4_with_bergs_rebase
alex-huth 84d233f
fix line length
alex-huth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be added to:
similarly to what was done in sis2: https://github.com/NOAA-GFDL/SIS2/blob/445cc36007118475c48c9934260cc33472896a18/src/ice_boundary_types.F90#L40-L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uramirez8707 I submitted PRs to add these fields and the null subroutine
unpack_ocean_ice_boundary_calved_shelf_bergsto all 3 repositories. I do not have appropriate scripts to compile and test, but the changes are straightforward.@nikizadehgfdl Tagging you as requested to help get these PRs approved.